Skip to content

Fix/clear motion state from status request #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mnaggatz wants to merge 4 commits into
base: master
Choose a base branch
from
+426 −5
Open

Fix/clear motion state from status request #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4554a4
Update opening device position from status requests
mnaggatz May 6, 2026
da88dda
Cover roller shutter status request position updates
mnaggatz May 6, 2026
60de12d
Expand node updater edge case coverage
mnaggatz May 6, 2026
bb197a9
Clear opening device motion from completed status requests
mnaggatz May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/pyvlx/node_updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
FrameBase, FrameCommandRunStatusNotification,
FrameGetAllNodesInformationNotification,
FrameNodeStatePositionChangedNotification, FrameStatusRequestNotification)
from .const import NodeParameter, OperatingState
from .const import NodeParameter, OperatingState, RunStatus
from .dimmable_device import DimmableDevice
from .log import PYVLXLOG
from .node import Node
Expand Down Expand Up @@ -89,6 +89,19 @@ async def process_frame_status_request_notification(
if position_lower_curtain.position <= Parameter.MAX:
node_changed |= _set_node_property(node, "position_lower_curtain", position_lower_curtain)

elif isinstance(node, OpeningDevice):
if NodeParameter(0) in frame.parameter_data: # MP
position = Position(frame.parameter_data[NodeParameter(0)])
if self._is_concrete_position(position):
node_changed |= _set_node_property(node, "position", position)
if frame.run_status == RunStatus.EXECUTION_COMPLETED:
if node.is_opening:
node_changed |= _set_node_property(node, "is_opening", False)
if node.is_closing:
node_changed |= _set_node_property(node, "is_closing", False)
node.state_received_at = None
node.estimated_completion = None

if node_changed:
await node.after_update()

Expand Down
Loading
Loading