fix: add reverse-dependency check to dream disable command#734
Merged
Lightheartdevs merged 1 commit intoLight-Heart-Labs:mainfrom Apr 3, 2026
Merged
Conversation
Warn users when disabling a service that other enabled extensions depend on, matching the behavior already present in the dashboard API. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Warn users when disabling a service that other enabled extensions depend on.
Why
cmd_disable()silently disabled services without checking if other extensions depend on them, leaving dependent extensions in a broken state on nextdream start. Bothcmd_enable()and the dashboard API already perform dependency checks.How
Iterate all enabled extensions'
SERVICE_DEPENDSentries, collect those referencing the target service, warn and prompt before proceeding.Testing
bash -n dream-clisyntax check ✅cmd_enablestylePlatform Impact
All platforms (Bash CLI)
🤖 Generated with Claude Code