Skip to content

fix: check permalink return and break out loop at 5#8

Open
E-Rick wants to merge 5 commits intomainfrom
fix-recommendation-permalinks
Open

fix: check permalink return and break out loop at 5#8
E-Rick wants to merge 5 commits intomainfrom
fix-recommendation-permalinks

Conversation

@E-Rick
Copy link
Contributor

@E-Rick E-Rick commented Jun 2, 2021

All Submissions:

Changes proposed in this Pull Request:

Fixes the display of articles. The get_recommendation function needed to break rather than return when count > 5. The returned string would be empty otherwise.

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@E-Rick E-Rick added the bug Something isn't working label Jun 2, 2021
@E-Rick E-Rick self-assigned this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant