Skip to content

fix: check permalink return and break out loop at 5 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
E-Rick wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: check permalink return and break out loop at 5 #8

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6a43db
fix: check permalink return and break out loop at 5
E-Rick Jun 2, 2021
cb288f2
fix: esc the wcp url
E-Rick Jun 2, 2021
5edb6d8
fix: add model attributes to list items
E-Rick Jun 2, 2021
a8f35a8
fix: put href assignment in the list items
E-Rick Jun 2, 2021
7d0c8ff
revert: fix href permalinks for recs
E-Rick Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions article-recommendations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,12 @@ function get_recommendations( $results, $id = 'recommendations' ) {
$count = 1;
$articles = "";
$list_items = "";
$model_attributes = "";
$count_array = ['one','two','three','four','five'];
foreach ( $results as $result ) {
// Limit 5 posts
if ( $count > 5 ) {
return;
break;
}

// Get score from result (Rec API)
Expand All @@ -206,19 +207,29 @@ function get_recommendations( $results, $id = 'recommendations' ) {
$model = $result["model"];
$post = $result["recommended_article"];

//$href = "href=https://www.washingtoncitypaper.com/{$rec['path']} >";
$post_id = $post['external_id'] ?? $post['ID']; // If Rec API result, get the 'external_id' else set to WP 'ID'
$title = $post['title'] ?? $post['post_title']; // If Rec API result, get the 'title' else set to WP 'post_title'
$post_title = apply_filters('the_title', $title, $post_id); // Display the post_title
$href = esc_url(get_permalink($post_id));
// If Rec API result, get the 'external_id' else set to WP 'ID'
$post_id = $post['external_id'] ?? $post['ID'];

// If Rec API result, get the 'title' else set to WP 'post_title'
$title = $post['title'] ?? $post['post_title'];

// Display the post_title
$post_title = apply_filters('the_title', $title, $post_id);

// If permalink returns false, no post found. Then use wcp link.
$href = "https://www.washingtoncitypaper.com{$post['path']}";

if( get_permalink( $post_id ) ){
$href = esc_url( get_permalink( $post_id ) );
};

// Create the attributes for model and article recommendation
$model_attributes = "data-vars-model-id={$model['id']} data-vars-model-status={$model['status']} data-vars-model-type={$model['type']} ";
$article_attributes = "data-vars-article-id={$post['external_id']} data-vars-rec-id={$post['id']} data-vars-position={$count} data-vars-score={$score} ";

$articles .= "data-vars-{$count_array[ $count - 1 ]}={$post['external_id']} ";

$list_items .= "<li><a id='{$id}_{$count}' {$article_attributes} {$href} </a>{$post_title}</li>";
// Add list item to string builder
$list_items .= "<li><a id='{$id}_{$count}' {$model_attributes} {$article_attributes} href={$href} >{$post_title}</a></li>";

$count++; // increase count
}
Expand Down Expand Up @@ -248,7 +259,7 @@ function get_recent_posts( $id = 'recentposts' ) {
foreach ( $posts as $post ) {
// Limit 5 posts
if ( $count > 5 ) {
return;
break;
}

// I can probably made a whole default model object and use nullish coal to default the values to null.
Expand Down Expand Up @@ -281,6 +292,7 @@ function get_recent_posts( $id = 'recentposts' ) {

$count++;
}

return "<ul id={$id} {$model_attributes} {$articles} >{$list_items}</ul>";
} // end of function get_recent_posts

Expand Down