Skip to content

Update canbed_dual.h#2

Open
thandal wants to merge 1 commit intoLongan-Labs:mainfrom
thandal:patch-3
Open

Update canbed_dual.h#2
thandal wants to merge 1 commit intoLongan-Labs:mainfrom
thandal:patch-3

Conversation

@thandal
Copy link

@thandal thandal commented Sep 7, 2022

Minor cleanup and comments

Minor cleanup and comments
@douardda
Copy link

This PR should be merged with #3 ; makes no sense to have this (useful) improvement in 2 different PRs (it makes a git revision which does not compile, which is bad).

@thandal
Copy link
Author

thandal commented Sep 15, 2022 via email

@douardda
Copy link

Sorry, my mistake (did the edits in the github editor and then didn't figure out how to merge 'em).

Yeah I imagined something like that :-)

Not sure how to combine 2 PRs in github (I do not use github to manipulate PRs and git commits). But I think it's possible to update your PR #3 to include the changes in the .h file then abandon this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants