Open
Conversation
Minor cleanup and comments
|
This PR should be merged with #3 ; makes no sense to have this (useful) improvement in 2 different PRs (it makes a git revision which does not compile, which is bad). |
Author
|
Sorry, my mistake (did the edits in the github editor and then didn't
figure out how to merge 'em).
…On Thu, Sep 15, 2022 at 5:27 PM David Douard ***@***.***> wrote:
This PR should be merged with #3
<#3> ; makes no
sense to have this (useful) improvement in 2 different PRs (it makes a git
revision which does not compile, which is bad).
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAT6ESAJ7MLNQLC2NMFSOBLV6OIF3ANCNFSM6AAAAAAQHGYWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yeah I imagined something like that :-) Not sure how to combine 2 PRs in github (I do not use github to manipulate PRs and git commits). But I think it's possible to update your PR #3 to include the changes in the .h file then abandon this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup and comments