feat: lock app into portrait mode #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mehdi-hamirifou
approved these changes
Dec 20, 2024
Contributor
mehdi-hamirifou
left a comment
mehdi-hamirifou
left a comment
There was a problem hiding this comment.
Great work! The feature works perfectly on phones, and good job adapting the tests to ensure everything runs smoothly. This is a solid improvement to the app's usability and consistency.
Approved for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with issue #313
Description:
This pull request addresses the need to lock the app in portrait mode for improved user experience and to ensure consistent behavior across all screens. By restricting the orientation to portrait mode, the app avoids unintended UI issues caused by rotation.
Changes Made:
Updated the AndroidManifest.xml to set screenOrientation to portrait for all activities.
Ensured the app maintains a consistent layout regardless of device rotation.
Tested the implementation to confirm the app behavior remains stable in portrait mode.
Key Benefits:
Prevents UI glitches caused by screen rotations.
Enhances usability, especially for layouts optimized for portrait mode.
Provides a smoother and more predictable user experience.