Extract shared MoneyInputLayout for input pages#904
Closed
Conversation
Pull the duplicated MoneyInputDisplay + ConvertedMoneySwitcher out of send-input and receive-input into features/shared/money-input-display. The new component composes the raw amount display with the currency switcher and takes the same props both consumers were already threading through.
The prop name now describes intent (fires on invalid input) rather than implementation (shake animation). Consumers still own the animation choice via useAnimation — this just clarifies the contract.
Composes useMoneyInput + useAnimation into a single hook so consumers don't wire them together manually. handleNumberInput is now single-arg (shake fires internally on invalid input). Also exposes showDecimal and inputErrorClassName so consumers don't derive them.
Consolidate useMoneyInputField, MoneyInputLayout, and the display components into a single money-input-layout module. The hook and layout are always used together so they live in one file. Display components are now internal — consumers compose via the layout's slots (children, actions, belowDisplay). Send uses belowDisplay for its destination row between the amount display and account selector.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
Author
|
we decided to not do this and just rebuild each component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to do this because when thinking about how to build transfers and buying bitcoin it made the most sense to make individual buy-input, recieve-input, and transfer-input rather than trying to coordinate it all in one component. Those PRs will build on this one.
There's 4 commits to the refactor