Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 13, 2025

Explanation

The rule @typescript-eslint/naming-convention was already disabled for most files, but it was set to warn in a few places still. It's now completely disabled instead.

This was done to reduce the set of changes that are part of the upcoming switch to error suppression (#6790), and also for consistency. We still want to use this rule, but we can gradually begin enforcing it in a more controlled manner using error suppression, across the entire repository at once rather than selectively.

References

Relates to #6790

These changes were extracted from the draft PR #7148

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Fully disables @typescript-eslint/naming-convention across overrides and thresholds, and cleans up a related inline disable.

  • ESLint config:
    • Remove @typescript-eslint/naming-convention from overrides in **/*.d.ts and packages/eth-block-tracker/**/*.ts in eslint.config.mjs.
  • Warning thresholds:
    • Drop @typescript-eslint/naming-convention entries from eslint-warning-thresholds.json for packages/eth-block-tracker/tests/buildDeferred.ts and packages/eth-block-tracker/tests/setupAfterEnv.ts.
  • Types:
    • Remove inline disable for @typescript-eslint/naming-convention in types/global.d.ts.

Written by Cursor Bugbot for commit a8f5e9e. This will update automatically on new commits. Configure here.

@Gudahtt Gudahtt marked this pull request as ready for review November 13, 2025 13:53
The rule `@typescript-eslint/naming-convention` was already disabled
for most files, but it was set to `warn` in a few places still. It's
now completely disabled instead.

This was done to reduce the set of changes that are part of the
upcoming switch to error suppression (#6790), and also for consistency.
We still want to use this rule, but we can gradually begin enforcing it
in a more controlled manner using error suppression, across the entire
repository at once rather than selectively.
@Gudahtt Gudahtt force-pushed the disable-naming-convention-warnings branch from 4bc7432 to a8f5e9e Compare November 13, 2025 14:12
@Gudahtt Gudahtt enabled auto-merge (squash) November 13, 2025 14:12
@Gudahtt Gudahtt merged commit d324207 into main Nov 13, 2025
271 checks passed
@Gudahtt Gudahtt deleted the disable-naming-convention-warnings branch November 13, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants