handle duplicate column names and extend list of quantities#122
handle duplicate column names and extend list of quantities#122
Conversation
AlrauneZ
commented
Sep 30, 2025
- extend list of standard names to cover relevant chemicals measured in constructed wetland pilot
- adding check on duplicate column names and giving warning: fix What happens if in case of multiple columns with same contaminant name? #104
raar1
left a comment
There was a problem hiding this comment.
Ok good work! I'll just have to trust you on the contaminant info but I have left some comments and suggestions for the rest of the code :)
…ation, extend testing
|
|
Extending the checking of duplicate quantities: not only after reading in data, but also after identification of standard column names. It might happen that the same quantity is given in excel/csv data with two or more non-standard names. This will create duplicate column names in standardized dataframe. |
raar1
left a comment
There was a problem hiding this comment.
It was indeed a good idea to handle this case. Perhaps in future we will want to force the user to specify allow_duplicates=True or something like that but for now this looks good.
|
[like] Zech, A. (Alraune) reacted to your message:
…________________________________
From: Robin Richardson ***@***.***>
Sent: Friday, October 3, 2025 1:37:11 PM
To: MiBiPreT/mibiscreen ***@***.***>
Cc: Zech, A. (Alraune) ***@***.***>; Author ***@***.***>
Subject: Re: [MiBiPreT/mibiscreen] handle duplicate column names and extend list of quantities (PR #122)
CAUTION: This email originated from outside of Utrecht University. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@raar1 approved this pull request.
It was indeed a good idea to handle this case. Perhaps in future we will want to force the user to specify allow_duplicates=True or something like that but for now this looks good.
—
Reply to this email directly, view it on GitHub<#122 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMQQU2FPNIV5F4TLQTZOEBD3VZ3YPAVCNFSM6AAAAACH4FQIIKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEOJZGAYTGNBXGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|


