Skip to content

handle duplicate column names and extend list of quantities#122

Merged
AlrauneZ merged 7 commits intomainfrom
119-extend-to-read-in-cw-data
Oct 3, 2025
Merged

handle duplicate column names and extend list of quantities#122
AlrauneZ merged 7 commits intomainfrom
119-extend-to-read-in-cw-data

Conversation

@AlrauneZ
Copy link
Contributor

@AlrauneZ AlrauneZ self-assigned this Sep 30, 2025
@AlrauneZ AlrauneZ added the enhancement New feature or request label Sep 30, 2025
@AlrauneZ AlrauneZ linked an issue Sep 30, 2025 that may be closed by this pull request
@AlrauneZ AlrauneZ added this to MIBIREM Sep 30, 2025
@AlrauneZ AlrauneZ marked this pull request as ready for review October 3, 2025 08:39
@AlrauneZ AlrauneZ requested a review from raar1 October 3, 2025 08:39
Copy link
Collaborator

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good work! I'll just have to trust you on the contaminant info but I have left some comments and suggestions for the rest of the code :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@AlrauneZ
Copy link
Contributor Author

AlrauneZ commented Oct 3, 2025

Extending the checking of duplicate quantities: not only after reading in data, but also after identification of standard column names. It might happen that the same quantity is given in excel/csv data with two or more non-standard names. This will create duplicate column names in standardized dataframe.

@AlrauneZ AlrauneZ requested a review from raar1 October 3, 2025 13:04
Copy link
Collaborator

@raar1 raar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was indeed a good idea to handle this case. Perhaps in future we will want to force the user to specify allow_duplicates=True or something like that but for now this looks good.

@AlrauneZ
Copy link
Contributor Author

AlrauneZ commented Oct 3, 2025 via email

@AlrauneZ AlrauneZ merged commit 0a5f284 into main Oct 3, 2025
9 checks passed
@AlrauneZ AlrauneZ deleted the 119-extend-to-read-in-cw-data branch October 3, 2025 13:39
@github-project-automation github-project-automation bot moved this to Done in MIBIREM Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Extend to read in CW data What happens if in case of multiple columns with same contaminant name?

2 participants