Fix null handling in ingestion and simulation services

[nodefather]

Summary

• add check for EventGrid connection string in ingestion service
• validate simulation results in Mycosoft integration service

Testing

• dotnet build NatureOS.sln
• npm test -- --passWithNoTests

---

https://chatgpt.com/codex/tasks/task_e_6885c85015c8832a8073b3c2312d787a

Summary by Sourcery

Improve null handling and validation in the ingestion and simulation services

Bug Fixes:

• Validate presence of EventGrid connection string and throw an error if missing in the ingestion service
• Check for null simulation results and throw an error if the Mycosoft integration service returns no result

[sourcery-ai]

Reviewer's Guide

This PR improves null and configuration validation by ensuring the EventGrid connection string is present in the ingestion service and that simulation results are not null in the Mycosoft integration service.

Class diagram for updated MycosoftIntegrationService null handling

classDiagram
    class MycosoftIntegrationService {
        +Task<HplSimulationResult> ProcessHplSimulationAsync(HplSimulationRequest request, CancellationToken cancellationToken)
    }
    class MyceliumSimResult
    MycosoftIntegrationService --> MyceliumSimResult : uses
    %% Highlight new null check
    note for MycosoftIntegrationService "Throws InvalidOperationException if simResult is null after deserialization"

Loading

Class diagram for updated EventGridPublisherClient initialization in ingestion service

classDiagram
    class Program {
        +EventGridPublisherClient EventGridPublisherClientFactory()
    }
    class EventGridPublisherClient
    class AzureKeyCredential
    Program --> EventGridPublisherClient : creates
    EventGridPublisherClient o-- AzureKeyCredential : uses
    %% Highlight new configuration check
    note for Program "Throws InvalidOperationException if EventGrid connection string is missing"

Loading

File-Level Changes

Change	Details	Files
Add validation for EventGrid connection string in ingestion service	Check for null or whitespace endpoint and throw InvalidOperationException Fallback EventGrid key to empty string Initialize EventGridPublisherClient with validated credentials	src/ingestion/Program.cs
Validate and handle null simulation results in MycosoftIntegrationService	Check if deserialized simulation result is null and throw InvalidOperationException Ensure downstream code only runs with a valid simResult	src/core-api/Services/MycosoftIntegrationService.cs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @nodefather - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/ingestion/Program.cs:41` </location>
<code_context>
+                throw new InvalidOperationException("EventGrid connection string is not configured");
+            }
+
+            var key = configuration["EventGridKey"] ?? string.Empty;
             return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));
         });
</code_context>

<issue_to_address>
Defaulting to an empty string for the EventGrid key may mask misconfiguration.

Constructing EventGridPublisherClient with an empty key may cause runtime authentication errors. Instead, throw an exception if the key is missing, as is done for the endpoint.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
            var key = configuration["EventGridKey"] ?? string.Empty;
            return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));
=======
            var key = configuration["EventGridKey"];
            if (string.IsNullOrWhiteSpace(key))
            {
                throw new InvalidOperationException("EventGrid key is not configured");
            }
            return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));
>>>>>>> REPLACE

</suggested_fix>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Defaulting to an empty string for the EventGrid key may mask misconfiguration.

Constructing EventGridPublisherClient with an empty key may cause runtime authentication errors. Instead, throw an exception if the key is missing, as is done for the endpoint.

Suggested change

	var key = configuration["EventGridKey"] ?? string.Empty;
	return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));
	var key = configuration["EventGridKey"];
	if (string.IsNullOrWhiteSpace(key))
	{
	throw new InvalidOperationException("EventGrid key is not configured");
	}
	return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));