Skip to content

Fix null handling in ingestion and simulation services #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nodefather wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

Fix null handling in ingestion and simulation services #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core-api/Services/MycosoftIntegrationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,10 @@ public async Task<HplSimulationResult> ProcessHplSimulationAsync(HplSimulationRe

simResponse.EnsureSuccessStatusCode();
var simResult = await simResponse.Content.ReadFromJsonAsync<MyceliumSimResult>(cancellationToken);
if (simResult == null)
{
throw new InvalidOperationException("Simulation service returned no result");
}

// Store results in MINDEX
await StoreSimulationResultAsync(simResult);
Expand Down
9 changes: 7 additions & 2 deletions src/ingestion/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,14 @@

services.AddSingleton(provider =>
{
var endpoint = configuration.GetConnectionString("EventGridConnectionString") ??
var endpoint = configuration.GetConnectionString("EventGridConnectionString") ??
configuration["EventGridConnectionString"];
var key = configuration["EventGridKey"] ?? "";
if (string.IsNullOrWhiteSpace(endpoint))
{
throw new InvalidOperationException("EventGrid connection string is not configured");
}

var key = configuration["EventGridKey"] ?? string.Empty;
return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));
Comment on lines +41 to 42
Copy link

@sourcery-ai sourcery-ai bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Defaulting to an empty string for the EventGrid key may mask misconfiguration.

Constructing EventGridPublisherClient with an empty key may cause runtime authentication errors. Instead, throw an exception if the key is missing, as is done for the endpoint.

Suggested change
var key = configuration["EventGridKey"] ?? string.Empty;
return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));
var key = configuration["EventGridKey"];
if (string.IsNullOrWhiteSpace(key))
{
throw new InvalidOperationException("EventGrid key is not configured");
}
return new EventGridPublisherClient(new Uri(endpoint), new AzureKeyCredential(key));

});

Expand Down
Loading