Skip to content

update release checklist#430

Merged
twicki merged 2 commits intoNOAA-GFDL:developfrom
twicki:update_release_checklist
Apr 14, 2026
Merged

update release checklist#430
twicki merged 2 commits intoNOAA-GFDL:developfrom
twicki:update_release_checklist

Conversation

@twicki
Copy link
Copy Markdown
Collaborator

@twicki twicki commented Apr 14, 2026

Description

With the move to pinned releases of NDSL used in pyFV3 (see here) we need to add to the release checklist to ensure we keep up to date on those as well.

How has this been tested?

no testing required, docs only change

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@twicki twicki requested a review from romanc April 14, 2026 13:55
Copy link
Copy Markdown
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's also add the pySHiELD repo. pace is already there and I'm not sure how verbose we want to be about pyMoist, especially since we don't have anything merged down to mainline GEOS.

@twicki
Copy link
Copy Markdown
Collaborator Author

twicki commented Apr 14, 2026

pyShield currently points to develop: https://github.com/NOAA-GFDL/pySHiELD/blob/1ed483cf854244fd02e59d5817d9332610042178/pyproject.toml#L43 . Should we move that to be tagged as well?

@fmalatino
Copy link
Copy Markdown
Contributor

pyShield currently points to develop: https://github.com/NOAA-GFDL/pySHiELD/blob/1ed483cf854244fd02e59d5817d9332610042178/pyproject.toml#L43 . Should we move that to be tagged as well?

I think in general we should always move to the current release for each of the dependencies, but I am open to other opinions.

@romanc
Copy link
Copy Markdown
Collaborator

romanc commented Apr 14, 2026

+1 for using released versions unless we have compelling reasons, e.g. when propagating breaking changes.

@twicki
Copy link
Copy Markdown
Collaborator Author

twicki commented Apr 14, 2026

update to the checklist done.

PR in SHiELD open to pin as well: NOAA-GFDL/pySHiELD#94

@twicki twicki added this pull request to the merge queue Apr 14, 2026
Merged via the queue into NOAA-GFDL:develop with commit f9bb58e Apr 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants