Skip to content

Pin the NDSL version to a release#94

Open
twicki wants to merge 2 commits intoNOAA-GFDL:developfrom
twicki:pin_ndsl
Open

Pin the NDSL version to a release#94
twicki wants to merge 2 commits intoNOAA-GFDL:developfrom
twicki:pin_ndsl

Conversation

@twicki
Copy link
Copy Markdown

@twicki twicki commented Apr 14, 2026

Description

As per discussion in NOAA-GFDL/NDSL#430, we move to released dependencies in pySHiELD as well.

How Has This Been Tested?
as long as the CI is happy, so are we

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

Copy link
Copy Markdown
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the Python versions too while we're here?

Comment thread pyproject.toml Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this update to be >=3.11.7, <3.14?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants