[NUsight] Fix svg path generation for lines rendering#1765
Open
KimKhangHoang wants to merge 1 commit intomainfrom
Open
[NUsight] Fix svg path generation for lines rendering#1765KimKhangHoang wants to merge 1 commit intomainfrom
KimKhangHoang wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes chart lines not rendering due to an invalid SVG path string.
The path was previously built by concatenating an array, creating invalid output. This change correctly joins segments and avoids duplicating the first point.
Pre-PR Checklist:
Have you
Reviewers, Note
The change is motivated by chart rendering in nusight. This path component also may be used elsewhere.