test gb200 #8074
test gb200 #8074
Conversation
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-1" |
📝 WalkthroughWalkthroughUpdated Jenkins pipeline to load a different Bloom shared library branch. Removed one waiver entry from the integration test skip list. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(1 hunks)tests/integration/test_lists/waives.txt(0 hunks)
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
| @@ -1,4 +1,4 @@ | |||
| @Library(['bloom-jenkins-shared-lib@main', 'trtllm-jenkins-shared-lib@main']) _ | |||
| @Library(['bloom-jenkins-shared-lib@dev-yuanjingx-block_failed_nodes', 'trtllm-jenkins-shared-lib@main']) _ | |||
There was a problem hiding this comment.
🧩 Analysis chain
Verify this dev branch change is intentional and temporary.
The shared library bloom-jenkins-shared-lib has been switched from @main to @dev-yuanjingx-block_failed_nodes. This appears to be a development/testing change.
Risks:
- Dev branches may be unstable, deleted, or force-pushed
- Pipeline behavior becomes unpredictable if the branch diverges
- Other users running this pipeline will use your experimental branch
If this is for testing the "block_failed_nodes" feature:
- Consider using a feature flag or parameter instead
- Document why this change is needed in the PR description
- Plan to revert to
@mainbefore merging, or ensure the dev branch is production-ready and will be maintained
🏁 Script executed:
#!/bin/bash
# Check if this dev branch reference appears in other pipeline files
rg -n "bloom-jenkins-shared-lib@dev-yuanjingx" --type=groovyLength of output: 132
🏁 Script executed:
#!/bin/bash
# Check all @Library declarations to understand normal patterns
rg -n "@Library" --type=groovy -C2Length of output: 1011
🏁 Script executed:
#!/bin/bash
# Check git log for this specific file to see the previous state
git log -n 5 --oneline -- jenkins/L0_Test.groovyLength of output: 306
🏁 Script executed:
#!/bin/bash
# Show the diff for this file to see what changed
git diff HEAD~1 HEAD -- jenkins/L0_Test.groovyLength of output: 428
Do not merge this dev branch reference to production.
The bloom-jenkins-shared-lib has been changed from @main to @dev-yuanjingx-block_failed_nodes. All other pipeline files in this repository use @main:
jenkins/BuildDockerImage.groovyuses@mainjenkins/Build.groovyuses@mainjenkins/L0_MergeRequest.groovyuses@main
This dev branch reference will cause all users running the L0_Test pipeline to execute your experimental code. If testing the "block_failed_nodes" feature is necessary, revert this line to @main before merging, or merge your changes to the shared library's main branch first.
🤖 Prompt for AI Agents
In jenkins/L0_Test.groovy around line 1, the shared library reference was
changed from @main to @dev-yuanjingx-block_failed_nodes which will cause the
pipeline to run experimental code for all users; revert the library reference
back to @main (or merge your feature branch into the shared library's main) so
the file uses @main like the other pipeline files, and ensure you do not leave
any dev-branch references before merging.
|
PR_Github #20292 [ run ] triggered by Bot |
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87
force-pushed
the
user/yuanjingx/test_gb200
branch
from
80739e5 to
d7ac37a
Compare
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-1" |
|
PR_Github #20292 [ run ] completed with state |
|
PR_Github #20297 [ run ] triggered by Bot |
|
PR_Github #20297 [ run ] completed with state |
Summary by CodeRabbit
Chores
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.