Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jenkins/L0_Test.groovy
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library(['bloom-jenkins-shared-lib@main', 'trtllm-jenkins-shared-lib@main']) _
@Library(['bloom-jenkins-shared-lib@dev-yuanjingx-block_failed_nodes', 'trtllm-jenkins-shared-lib@main']) _
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify this dev branch change is intentional and temporary.

The shared library bloom-jenkins-shared-lib has been switched from @main to @dev-yuanjingx-block_failed_nodes. This appears to be a development/testing change.

Risks:

  • Dev branches may be unstable, deleted, or force-pushed
  • Pipeline behavior becomes unpredictable if the branch diverges
  • Other users running this pipeline will use your experimental branch

If this is for testing the "block_failed_nodes" feature:

  • Consider using a feature flag or parameter instead
  • Document why this change is needed in the PR description
  • Plan to revert to @main before merging, or ensure the dev branch is production-ready and will be maintained

🏁 Script executed:

#!/bin/bash
# Check if this dev branch reference appears in other pipeline files
rg -n "bloom-jenkins-shared-lib@dev-yuanjingx" --type=groovy

Length of output: 132


🏁 Script executed:

#!/bin/bash
# Check all @Library declarations to understand normal patterns
rg -n "@Library" --type=groovy -C2

Length of output: 1011


🏁 Script executed:

#!/bin/bash
# Check git log for this specific file to see the previous state
git log -n 5 --oneline -- jenkins/L0_Test.groovy

Length of output: 306


🏁 Script executed:

#!/bin/bash
# Show the diff for this file to see what changed
git diff HEAD~1 HEAD -- jenkins/L0_Test.groovy

Length of output: 428


Do not merge this dev branch reference to production.

The bloom-jenkins-shared-lib has been changed from @main to @dev-yuanjingx-block_failed_nodes. All other pipeline files in this repository use @main:

  • jenkins/BuildDockerImage.groovy uses @main
  • jenkins/Build.groovy uses @main
  • jenkins/L0_MergeRequest.groovy uses @main

This dev branch reference will cause all users running the L0_Test pipeline to execute your experimental code. If testing the "block_failed_nodes" feature is necessary, revert this line to @main before merging, or merge your changes to the shared library's main branch first.

🤖 Prompt for AI Agents
In jenkins/L0_Test.groovy around line 1, the shared library reference was
changed from @main to @dev-yuanjingx-block_failed_nodes which will cause the
pipeline to run experimental code for all users; revert the library reference
back to @main (or merge your feature branch into the shared library's main) so
the file uses @main like the other pipeline files, and ensure you do not leave
any dev-branch references before merging.


import java.lang.InterruptedException
import groovy.transform.Field
Expand Down
1 change: 0 additions & 1 deletion tests/integration/test_lists/waives.txt
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ accuracy/test_llm_api.py::TestPhi4MiniInstruct::test_fp8 SKIP (https://nvbugs/54
accuracy/test_llm_api_pytorch.py::TestEXAONE4::test_auto_dtype SKIP (https://nvbugs/5481090)
accuracy/test_llm_api_pytorch.py::TestLlama4MaverickInstruct::test_fp8_eagle3[tp8-torch_compile=False] SKIP (https://nvbugs/5483534)
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16_4gpus_online_eplb[mtp_nextn=2] SKIP (https://nvbugs/5444687)
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus_online_eplb[fp8kv=True] SKIP (https://nvbugs/5444687)
accuracy/test_disaggregated_serving.py::TestLlama3_1_8BInstruct::test_ngram SKIP (https://nvbugs/5488118)
test_e2e.py::test_trtllm_bench_iteration_log[TRT-streaming-meta-llama/Llama-3.1-8B-llama-3.1-model/Meta-Llama-3.1-8B] SKIP (https://nvbugs/5448523)
cpp/test_unit_tests.py::test_unit_tests[kernels-80] SKIP (https://nvbugs/5504078)
Expand Down
Loading