Conversation
yanchangNvidia
left a comment
yanchangNvidia
left a comment
There was a problem hiding this comment.
Overall it looks great to me. Left some comments.
| ``` | ||
|
|
||
| ### Step 2 - Build a scenario | ||
| ### Step 2 - Load a stage |
There was a problem hiding this comment.
"scene" seems more commonly used than "stage"?
| @@ -0,0 +1,111 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Why there is a "05" in the file title?
There was a problem hiding this comment.
This is given because this script is currently listed as an example (number 5). The purpose of the numbering is to provide developers with a rough progression to follow. I find this pattern helpful when I see it in other projects, like NVISII.
Maybe we should instead place this under "scripts", which is unordered, and meant more for direct usage, not modification
|
|
||
| if dist_to_target < self.robot.path_following_stop_distance_threshold: | ||
| self.set_random_target_path() | ||
| self.is_alive = False |
There was a problem hiding this comment.
This might cause a new data folder will be created every time when the robot reaches a target, and the recording segment will be very short.
3 participants
Testing