fix: stabilize transcription session state and diarization fallback#8
Closed
Newarr wants to merge 1 commit intostack/logging-cleanupfrom
Closed
fix: stabilize transcription session state and diarization fallback#8Newarr wants to merge 1 commit intostack/logging-cleanupfrom
Newarr wants to merge 1 commit intostack/logging-cleanupfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR stabilizes transcription session model selection, makes diarization failures degrade visibly instead of silently, keeps renamed settings rollback-safe, and aligns the re-transcription notification copy.
Why
This is the second PR in a 2-PR stack, and it depends on #7.
The main issue here was not one isolated bug. The engine was still rereading mutable settings after startup, which meant the requested transcription model could drift during the same session. On top of that, diarization failures could disappear silently, and renamed settings keys were only safe in one direction.
Separating this from the logger cleanup keeps the review focused on behavior.
How
Re-transcriptionvadManagerand remove dead engine error codeTesting
swift testMigration / rollback
No schema migration.
Rollback is straightforward, and the settings changes explicitly preserve downgrade compatibility by continuing to write the legacy keys.
Stack
stack/logging-cleanupin the fork to keep the stacked diff small until the upstream base work is ready