-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
python3Packages.beancount: 2.3.6 -> 3.1.0 #371541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am not using v3 currently. How is it working with existing tools now? |
I used v3 for the last 6 months, and it works ok for me. However, I don't use any custom importers based on Overall, I think it is in good enough shape for everyday use, but it depends on your setup. |
|
It would be nice to have v3 in nixpkgs. But since there are major incompatibilities between v2 and v3, and v2 is still widely used, I would like to keep both v2 and v3 in nixpkgs, i.e. |
|
Ok, makes sense. I reworked PR: added separate package for beancount3 and support for building fava with either version. This way user can specify |
4faf5eb to
85ca22d
Compare
dotlambda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message needs to be adapted. I suggest
python313Packages.beancount: 2.3.6 -> 3.1.0python313Packages.beancount_2: init at 2.3.6
It might make sense to set |
|
Added comment in |
|
|
@dotlambda Thanks for your patience and feedback while moving this PR forward. |
Add package for beancount v3
Add package for
beangulpas a replacement forbeancount.ingestUpdate package for
beanqueryto use snapshot version that using TatSu-LTS dependency: beancount/beanquery#226Update
favato version 1.30.1 which supports bothbeancount2andbeancount3.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.