Skip to content

etesync-dav: fix compatibility with Radicale 3.6#494473

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
phaer:fix/etesync-dav
Mar 3, 2026
Merged

etesync-dav: fix compatibility with Radicale 3.6#494473
Aleksanaa merged 1 commit intoNixOS:masterfrom
phaer:fix/etesync-dav

Conversation

@phaer
Copy link
Copy Markdown
Member

@phaer phaer commented Feb 26, 2026

Radicale 3.5.5 changed the upload() return type to a 2-tuple and Radicale 3.5.10 changed WSGIResponse from a 3-tuple to a 4-tuple. Proposed for upstreaming in etesync/etesync-dav#365

The test was broken since december but passes now

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from Valodim February 26, 2026 20:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Feb 26, 2026
Radicale 3.5.5 changed the upload() return type to a 2-tuple and
Radicale 3.5.10 changed WSGIResponse from a 3-tuple to a 4-tuple.

Proposed for upstreaming in etesync/etesync-dav#365
@phaer phaer requested a review from Aleksanaa March 3, 2026 11:29
@Aleksanaa Aleksanaa added this pull request to the merge queue Mar 3, 2026
Merged via the queue into NixOS:master with commit 8c809a1 Mar 3, 2026
29 of 31 checks passed
@phaer phaer deleted the fix/etesync-dav branch March 3, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants