Conversation
| // | ||
| // In this case, the entire walk is started over and B 1.0.0 is left out of the graph, leading to C 1.0.0 and D 1.0.0 also being left out. | ||
| // | ||
| // Used to start over when a dependency has multiple descendants of an item to be evicted. |
There was a problem hiding this comment.
This comment is on the StartOver label.
I feel like the formatter is incorrect here. I know it's aligning things to the rest of the code, but it feels like it shouldn't.
I wonder if there's a fix in the analyzers that's intentional or an accidental thing.
There was a problem hiding this comment.
D:\a\1\s\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(944,9): error WHITESPACE: Fix whitespace formatting. Delete 4 characters. [D:\a\1\s\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj]
D:\a\1\s\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(945,9): error WHITESPACE: Fix whitespace formatting. Delete 4 characters.
There was a problem hiding this comment.
Why isn't our CI failing?
NuGet.Client/eng/pipelines/pr.yml
Lines 285 to 286 in b8bbe4b
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
Bug N/A (Engineering task)
Fixes: Whitespace format warnings
Description
Building dev branch locally has produced below IDE0055: Fix formatting warnings. Used
dotnet format whitespace NuGet.slnto fix these warnings.PR Checklist
[ ] Added tests[ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.