Skip to content

fix whitespace format warnings#7211

Draft
kartheekp-ms wants to merge 1 commit intodevfrom
dev-kmps-fix-format-issues-dev
Draft

fix whitespace format warnings#7211
kartheekp-ms wants to merge 1 commit intodevfrom
dev-kmps-fix-format-issues-dev

Conversation

@kartheekp-ms
Copy link
Copy Markdown
Contributor

@kartheekp-ms kartheekp-ms commented Mar 12, 2026

Bug N/A (Engineering task)

Fixes: Whitespace format warnings

Description

Building dev branch locally has produced below IDE0055: Fix formatting warnings. Used dotnet format whitespace NuGet.sln to fix these warnings.

$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(944,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(945,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(946,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(947,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(948,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(949,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(950,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(951,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(952,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(953,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(954,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(955,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(956,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(957,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(958,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(959,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(960,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(961,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(962,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net472]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(944,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(945,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(946,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(947,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(948,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(949,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(950,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(951,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(952,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(953,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(954,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(955,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(956,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(957,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(958,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(959,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(960,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(961,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
$\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(962,9): warning IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [$\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj::TargetFramework=net8.0]
.vsixignore : warning : Missing 4 ignored file(s) 'Google.Protobuf.dll;Microsoft.Bcl.HashCode.dll;Microsoft.ML.Tokenizers.dll;Microsoft.VisualStudio.Copilot.dll' [$\src\NuGet.Clients\NuGet.VisualStudio.Client\NuGet.VisualStudio.Client.csproj]
39 Warning(s)
0 Error(s)

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • [ ] Added tests
  • [ ] Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@kartheekp-ms kartheekp-ms requested a review from a team as a code owner March 12, 2026 21:54
@kartheekp-ms kartheekp-ms added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Mar 12, 2026
@kartheekp-ms kartheekp-ms requested review from nkolev92 and zivkan March 12, 2026 21:54
//
// In this case, the entire walk is started over and B 1.0.0 is left out of the graph, leading to C 1.0.0 and D 1.0.0 also being left out.
//
// Used to start over when a dependency has multiple descendants of an item to be evicted.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is on the StartOver label.

I feel like the formatter is incorrect here. I know it's aligning things to the rest of the code, but it feels like it shouldn't.

I wonder if there's a fix in the analyzers that's intentional or an accidental thing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed for this branch.

D:\a\1\s\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(944,9): error WHITESPACE: Fix whitespace formatting. Delete 4 characters. [D:\a\1\s\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj]
D:\a\1\s\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(945,9): error WHITESPACE: Fix whitespace formatting. Delete 4 characters. 

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you meant to reply to @zivkan instead

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't our CI failing?

- script: dotnet format whitespace --verify-no-changes NuGet.sln
displayName: Run dotnet format whitespace

@kartheekp-ms kartheekp-ms marked this pull request as draft March 18, 2026 18:43
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Mar 25, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Engineering Changes related to the build infrastructure of the repo and that do not change product code Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants