Skip to content

fix whitespace format warnings #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kartheekp-ms wants to merge 1 commit into
base: dev
Choose a base branch
from
+19 −19
Draft

fix whitespace format warnings #7211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/NuGet.Core/NuGet.Commands/RestoreCommand/DependencyGraphResolver.cs
View file
Open in desktop
Copy link
Copy Markdown
Member

@zivkan zivkan Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't our CI failing?

NuGet.Client/eng/pipelines/pr.yml

Lines 285 to 286 in b8bbe4b

- script: dotnet format whitespace --verify-no-changes NuGet.sln
displayName: Run dotnet format whitespace

Original file line number Diff line number Diff line change
Expand Up @@ -941,25 +941,25 @@ private async Task<Dictionary<LibraryDependencyIndex, ResolvedDependencyGraphIte
// Used when logging package id specific messages, we need to know the target graph name
string targetGraphName = pair.Name;

// Used to start over when a dependency has multiple descendants of an item to be evicted.
//
// Project
// ├── A 1.0.0
// │ └── B 1.0.0
// │ └── C 1.0.0
// │ └── D 1.0.0
// └── X 2.0.0
// └── Y 2.0.0
// └── G 2.0.0
// └── B 2.0.0
// The items are processed in the following order:
// Chose A 1.0.0 and X 1.0.0
// Chose B 1.0.0 and Y 2.0.0
// Chose C 1.0.0 and G 2.0.0
// Chose D 1.0.0 and B 2.0.0, but B 2.0.0 should evict C 1.0.0 and D 1.0.0
//
// In this case, the entire walk is started over and B 1.0.0 is left out of the graph, leading to C 1.0.0 and D 1.0.0 also being left out.
//
// Used to start over when a dependency has multiple descendants of an item to be evicted.
Copy link
Copy Markdown
Member

@nkolev92 nkolev92 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is on the StartOver label.

I feel like the formatter is incorrect here. I know it's aligning things to the rest of the code, but it feels like it shouldn't.

I wonder if there's a fix in the analyzers that's intentional or an accidental thing.

Copy link
Copy Markdown
Contributor Author

@kartheekp-ms kartheekp-ms Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed for this branch.

D:\a\1\s\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(944,9): error WHITESPACE: Fix whitespace formatting. Delete 4 characters. [D:\a\1\s\src\NuGet.Core\NuGet.Commands\NuGet.Commands.csproj]
D:\a\1\s\src\NuGet.Core\NuGet.Commands\RestoreCommand\DependencyGraphResolver.cs(945,9): error WHITESPACE: Fix whitespace formatting. Delete 4 characters.

Copy link
Copy Markdown
Member

@nkolev92 nkolev92 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you meant to reply to @zivkan instead

//
// Project
// ├── A 1.0.0
// │ └── B 1.0.0
// │ └── C 1.0.0
// │ └── D 1.0.0
// └── X 2.0.0
// └── Y 2.0.0
// └── G 2.0.0
// └── B 2.0.0
// The items are processed in the following order:
// Chose A 1.0.0 and X 1.0.0
// Chose B 1.0.0 and Y 2.0.0
// Chose C 1.0.0 and G 2.0.0
// Chose D 1.0.0 and B 2.0.0, but B 2.0.0 should evict C 1.0.0 and D 1.0.0
//
// In this case, the entire walk is started over and B 1.0.0 is left out of the graph, leading to C 1.0.0 and D 1.0.0 also being left out.
//
StartOver:
restartCount++;

Expand Down
Loading