Skip to content

Fix dialect link from 3.1 to 3.2 #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

Fix dialect link from 3.1 to 3.2 #4994

merged 2 commits into from
Sep 30, 2025

Conversation

valerii15298
Copy link

@valerii15298 valerii15298 commented Sep 25, 2025 •
edited by karenetheridge
Loading

Fixes dialect link

  • no schema changes are needed for this pull request

@valerii15298 valerii15298 requested review from a team as code owners September 25, 2025 13:40
@valerii15298 valerii15298 mentioned this pull request Sep 25, 2025
Closed
3 tasks
@karenetheridge karenetheridge mentioned this pull request Sep 25, 2025
Open
mikekistler
mikekistler previously approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@baywet
Copy link
Contributor

baywet commented Sep 25, 2025

@valerii15298 can you please also stand up the same exact PR for 3.3-dev as well?

@valerii15298 valerii15298 changed the base branch from v3.2-dev to v3.3-dev September 25, 2025 16:31
@valerii15298 valerii15298 dismissed mikekistler’s stale review September 25, 2025 16:31

The base branch was changed.

@valerii15298 valerii15298 changed the base branch from v3.3-dev to v3.2-dev September 25, 2025 16:34
@valerii15298
Copy link
Author

@baywet I created PR targeting 3.3 dev: #4996

I used 3.3 version in the dialect link since it is for 3.3

ralfhandl
ralfhandl previously approved these changes Sep 25, 2025
View reviewed changes
@ralfhandl ralfhandl requested review from a team and mikekistler September 25, 2025 17:01
@ralfhandl ralfhandl added this to the v3.2.1 milestone Sep 25, 2025
@karenetheridge karenetheridge mentioned this pull request Sep 25, 2025
Open
karenetheridge
karenetheridge previously requested changes Sep 26, 2025
View reviewed changes
@valerii15298 @karenetheridge
Update oas.md
eba740d 
Co-authored-by: Karen Etheridge <ether@cpan.org>
@ralfhandl ralfhandl requested review from karenetheridge and a team September 30, 2025 11:41
mikekistler
mikekistler approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl dismissed karenetheridge’s stale review September 30, 2025 13:18

Last change seems identical to @karenetheridge‘s proposal

@ralfhandl ralfhandl merged commit 0f65e95 into OAI:v3.2-dev Sep 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfhandl ralfhandl ralfhandl approved these changes

@mikekistler mikekistler mikekistler approved these changes

@karenetheridge karenetheridge Awaiting requested review from karenetheridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@valerii15298 @baywet @karenetheridge @ralfhandl @mikekistler