[ADD] lims

[max3903]

#13

@hector-fe-dev
@jasiel-osi
@madridrodrigo

[NICO-SOLUTIONS]

@max3903
Hey. As there is this PR already...
Looks like the given structure is fxed?! Wrote you on dicord.
Cheers Nils

[etobella]

@max3903 I made a fast review. A few recommendations of my experience doing a vertical for healthcare.

• On Medical FHIR we did the same job of splitting and creating specific entities for everything, however, time showed us that it was a bad choice. Operators, laboratories and so on are res.partners. You don't need to create a new entities for them with a state field. Just use a flag for it. At the end, we removed all the complicated logic to more simpler entities.
• You added batches in your first approach. It is interesting but it might make the system overcomplicated and could be added easily later on a second module
• The system of shared stages is interesting but it might make things overcomplicated. I don't recomend to use that. It is better to keep things simple and make one stage model for each important model.

In a few words, I recommend you to keep things simple. I have seen a lot of cases in healthcare where people explains the weirdest cases at the begining trying to show that their process is supercomplicated, but it is usually simpler than they show us.

My 2 cts.

[etobella]

Another thing, I have the feeling that you are duplicating Odoo records with this approach, let me explain myself:

The launcher of everything here will be a sale.order. For me a sale.order is quite similar to a lims.order. I think we should need to assume that sale.order == lims.order and simplify from that point on. Otherwise, it will be overcomplicated for internal user. When the sale.order is confirmed, a lims.sample and lims.line is created depending on the configuration (also, it allows the splitting, for example, buying an aggregated service that will create several lines).

This way, everything gets more sense. I will make a migration of my original module based on an OpenSource software specific for labs. It doesn't include batches or resources, but that is a second round for me.

Actually, that might be functional for a basic laboratory, but it includes all the basic information and a flow for validation.

I will propose the PR to clash with this, but just to show how it should be IMO.

[etobella]

@max3903 Did you review my comments?

[etobella]

/ocabot rebase

[OCA-git-bot]

@etobella The rebase process failed, because command git push --force ursais tmp-pr-20:18.0-add-lims failed with output:

remote: Repository not found.
fatal: repository 'https://github.com/ursais/connector-lims/' not found

[etobella]

Can you rebase?