[17.0][MIG] account_invoice_overdue_reminder: Migration to 17.0 #372

NICO-SOLUTIONS · 2024-03-25T09:10:37Z

migration to 17.0

HaraldPanten · 2024-06-20T16:30:23Z

/ocabot migration account_invoice_overdue_reminder

github-actions · 2025-05-11T12:16:12Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

FranciscoExposito · 2025-05-27T10:44:25Z

Hello! I'd like to test this PR, could you please enable the runboat? @NICO-SOLUTIONS

NICO-SOLUTIONS · 2025-05-27T13:24:11Z

Hello! I'd like to test this PR, could you please enable the runboat? @NICO-SOLUTIONS

rebased... i started including some tests a while ago... but havent finished it for now

FranciscoExposito · 2025-06-11T15:26:50Z

Functional review:

Encountered an error when attempting to generate a record with 'reminder type = phone'

_Traceback (most recent call last):
File "/opt/odoo/odoo/http.py", line 1803, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/odoo/service/model.py", line 152, in retrying
result = func()
File "/opt/odoo/odoo/http.py", line 1831, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/odoo/http.py", line 2035, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 221, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/odoo/http.py", line 772, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/addons/web/controllers/dataset.py", line 29, in call_button
action = self._call_kw(model, method, args, kwargs)
File "/opt/odoo/addons/web/controllers/dataset.py", line 21, in _call_kw
return call_kw(Model, method, args, kwargs)
File "/opt/odoo/odoo/api.py", line 484, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/odoo/api.py", line 469, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/mnt/data/odoo-addons-dir/account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py", line 517, in validate
vals = rec.validate_phone()
AttributeError: 'overdue.reminder.step' object has no attribute 'validate_phone'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPC_ERROR
at makeErrorFromResponse (http://oca-credit-control-17-0-pr372-53ce336d0592.runboat.odoo-community.org/web/assets/7096fdb/web.assets_web.min.js:2943:163)
at XMLHttpRequest. (http://oca-credit-control-17-0-pr372-53ce336d0592.runboat.odoo-community.org/web/assets/7096fdb/web.assets_web.min.js:2947:13)_

NICO-SOLUTIONS · 2025-06-11T17:24:57Z

Functional review:

Encountered an error when attempting to generate a record with 'reminder type = phone'

_Traceback (most recent call last): File "/opt/odoo/odoo/http.py", line 1803, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "/opt/odoo/odoo/service/model.py", line 152, in retrying result = func() File "/opt/odoo/odoo/http.py", line 1831, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "/opt/odoo/odoo/http.py", line 2035, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File....

@FranciscoExposito
Sorry, my bad. lost def validate_phone unintentionally...

account_invoice_overdue_reminder/views/res_partner.xml

peluko00 · 2025-08-22T05:34:35Z

Can you push again please @NICO-SOLUTIONS ?

NICO-SOLUTIONS · 2025-08-22T11:41:43Z

@peluko00
rebased...

…instead of supplier invoice form

…update your mail templates) Add ability to add contacts as Cc of the reminder email (added to the Cc of the mail template) Add partner_policy with 3 options to give some choice about which contact should be selected to send reminders Access reminders from partner via Action menu

…mail vals generation

…mplate

…achment_ids

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-15.0/credit-control-15.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-15-0/credit-control-15-0-account_invoice_overdue_reminder/

result_notes fields converted from fields.Text to fields.Html In mass view of steps, show buttons in tree view Fix carriage return in subject of email, which may block the email Fix crash when validating several steps at the same time in the mass update interface Forword port PR OCA#236 and OCA#240 [UPD] Update account_invoice_overdue_reminder.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/

Remove the end step in the wizard (replaced by a notification) Remove the up_to_date boolean on the start wizard Code cleanup [UPD] Update account_invoice_overdue_reminder.pot account_invoice_overdue_reminder 16.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/ Update __manifest__.py "application": False,

Translated using Weblate (Dutch) Currently translated at 93.4% (170 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/nl/ [UPD] README.rst Added translation using Weblate (Spanish) Translated using Weblate (Spanish) Currently translated at 78.5% (143 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (182 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/es/

Translated using Weblate (Portuguese) Currently translated at 96.1% (175 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/pt/ Translated using Weblate (Portuguese) Currently translated at 100.0% (182 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/pt/ Translated using Weblate (Portuguese) Currently translated at 100.0% (182 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/pt/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/ Translated using Weblate (Dutch) Currently translated at 93.4% (170 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/nl/

…between instances of 'bool' and 'datetime.date' Translated using Weblate (Dutch) Currently translated at 93.4% (170 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/nl/ Translated using Weblate (Dutch) Currently translated at 93.4% (170 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/nl/

[BOT] post-merge updates

…-mail Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be> [UPD] Update account_invoice_overdue_reminder.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/ [BOT] post-merge updates Translated using Weblate (Spanish) Currently translated at 100.0% (181 of 181 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/es/ [UPD] Update account_invoice_overdue_reminder.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/ Translated using Weblate (Spanish) Currently translated at 100.0% (182 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/es/ Translated using Weblate (French) Currently translated at 100.0% (182 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/fr/

Translated using Weblate (German) Currently translated at 15.3% (28 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/de/ Translated using Weblate (German) Currently translated at 93.9% (171 of 182 strings) Translation: credit-control-16.0/credit-control-16.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_invoice_overdue_reminder/de/

jelenapoblet · 2025-11-18T16:49:41Z

@FranciscoExposito can you validate functional review please ?

NICO-SOLUTIONS · 2025-11-18T17:04:37Z

@jelenapoblet
In the meantime, another PR for the migration from Odoo 16 to 18 has already been merged (history here: https://github.com/OCA/credit-control/commits/18.0/account_invoice_overdue_reminder). That 16→18 PR includes several changes that are also relevant for the 16→17 migration and should potentially be backported.

We should check whether these changes also need to be applied to the 17 branch. A backport to 17.0 might be advisable to ensure consistency across versions.

jelenapoblet · 2025-11-21T13:53:07Z

I think your suggestion makes sense, the backport idea might be the best way to go. If that's the case, we should proceed and we'll support with reviews.

NICO-SOLUTIONS · 2025-11-23T13:11:29Z

superseeded by #523

NICO-SOLUTIONS mentioned this pull request Mar 25, 2024

Migration to version 17.0 #338

Open

11 tasks

NICO-SOLUTIONS marked this pull request as ready for review March 25, 2024 09:14

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from c11e1a7 to fe21ceb Compare March 25, 2024 10:25

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from fe21ceb to 508282a Compare May 16, 2024 14:59

OCA-git-bot added this to the 17.0 milestone Jun 20, 2024

cvinh approved these changes Sep 8, 2024

View reviewed changes

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch 2 times, most recently from 2c552a8 to f03fcc9 Compare October 8, 2024 09:51

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from f03fcc9 to 72ac3a2 Compare January 8, 2025 11:23

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 11, 2025

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from 72ac3a2 to 53ce336 Compare May 27, 2025 13:20

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 1, 2025

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from 53ce336 to b827a5d Compare June 11, 2025 17:18

cvinh reviewed Jun 17, 2025

View reviewed changes

account_invoice_overdue_reminder/views/res_partner.xml Outdated Show resolved Hide resolved

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from b827a5d to 4ee42df Compare June 18, 2025 13:14

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from 4ee42df to 53f4bab Compare August 22, 2025 11:38

alexis-via added 6 commits October 16, 2025 17:11

Add module account_invoice_overdue_reminder

4591a48

Switch row and col in pivot view of overdue reminders

3d926aa

overdue_reminder: explicit error when email is missing

25532c5

[FIX] overdue_reminder: don't link mail.template to a wizard record !

5d731d6

overdue_reminder: use form_view_ref to display customer invoice form …

2cb69d2

…instead of supplier invoice form

JordiMForgeFlow and others added 23 commits October 16, 2025 17:11

[IMP] account_invoice_overdue_reminder: decouple mail validation and …

503367b

…mail vals generation

[IMP] account_invoice_overdue_reminder: black, isort, prettier

b72d2a3

[MIG] account_invoice_overdue_reminder: Migration to 15.0

7703bd3

[IMP] account_invoice_overdue_reminder: add method to get reminder te…

ec65694

…mplate

[IMP] account_invoice_overdue_reminder: add the method to get the att…

de5cab0

…achment_ids

[UPD] Update account_invoice_overdue_reminder.pot

8bb6b2f

[UPD] README.rst

e66b9cf

[IMP] account_invoice_overdue_reminder: hide button if reminded

8e3bb79

[16.0] account_invoice_overdue_reminder: remind partially paid invoices

c0ba443

[IMP] account_invoice_overdue_reminder: code review

5f18c96

[BOT] post-merge updates

[IMP] account_invoice_overdue_reminder: Add credit notes to overdue e…

eda8a1b

…-mail Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

[IMP] account_invoice_overdue_reminder: Remove unreconciled button

bbb0761

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

[IMP] account_invoice_overdue_reminder: Change log

9aa1186

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

[IMP] account_invoice_overdue_reminder: pre-commit auto fixes

c5593d5

[MIG] account_invoice_overdue_reminder: Migration to 17.0

f982f7a

NICO-SOLUTIONS force-pushed the 17.0-mig-account_invoice_overdue_reminder branch from 53f4bab to f982f7a Compare October 16, 2025 15:12

NICO-SOLUTIONS closed this Nov 23, 2025

NICO-SOLUTIONS deleted the 17.0-mig-account_invoice_overdue_reminder branch January 1, 2026 12:59

Uh oh!

[17.0][MIG] account_invoice_overdue_reminder: Migration to 17.0 #372

[17.0][MIG] account_invoice_overdue_reminder: Migration to 17.0 #372

Uh oh!

Conversation

NICO-SOLUTIONS commented Mar 25, 2024

Uh oh!

HaraldPanten commented Jun 20, 2024

Uh oh!

github-actions bot commented May 11, 2025

Uh oh!

FranciscoExposito commented May 27, 2025

Uh oh!

NICO-SOLUTIONS commented May 27, 2025

Uh oh!

FranciscoExposito commented Jun 11, 2025

Uh oh!

NICO-SOLUTIONS commented Jun 11, 2025

Uh oh!

Uh oh!

peluko00 commented Aug 22, 2025

Uh oh!

NICO-SOLUTIONS commented Aug 22, 2025

Uh oh!

jelenapoblet commented Nov 18, 2025

Uh oh!

NICO-SOLUTIONS commented Nov 18, 2025

Uh oh!

jelenapoblet commented Nov 21, 2025

Uh oh!

NICO-SOLUTIONS commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants