-
-
Notifications
You must be signed in to change notification settings - Fork 303
[17.0][MIG] web_view_leaflet_map #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
…om 1.8.0, released on April 18, 2022.)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/
Currently translated at 100.0% (7 of 7 strings) Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/it/
…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map/
…om 1.8.0, released on April 18, 2022.)
Currently translated at 100.0% (2 of 2 strings) Translation: geospatial-16.0/geospatial-16.0-web_view_leaflet_map_partner Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-web_view_leaflet_map_partner/it/
This reverts commit a9570109
LoxoLueiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Will this feature be merge into 17.0? |
|
/ocabot migration web_view_leaflet_map @legalsylvain is it OK for you? |
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. yes, V18 is working on top of this PR V17. So 👍
note: @cesarportas : I re-refactored recently this module, if you want to cherry pick. (not a blocking point, as your PR is not at the HEAD branch).
See :
#434
Note 2 : if you have any idea to fix the "no search bar problem", please ping me.
In the meantime
/ocabot merge nobump
|
What a great day to merge this nice PR. Let's do it! |
|
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-415-by-legalsylvain-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
hi @cesarportas : could you rebase, and take a look on the CI ? thanks ! |
This PR migrates the module web_view_leaflet_map to the target version, including a full refactor to OWL framework.