Skip to content

Conversation

@sysadminmatmoz
Copy link
Member

I use it as a tool for the relationship graph mostly, but it could be handy for someone else too.

Fresh PR since I messed up my previous git repo.

Added Pedro's change requests in README (todo) and the fact, that it performs it's actions only on actually installed modules in description.

The image gets presented only for the modules that are really currently installed (not just present as installable) in the same database where you run the creation button. The RST is the sphinx RST (as defined in description) - the output file is a gzip archive containing index.rst, module.rst and relations graph.

relation_graph

and sphinx output after make html:
sphinx1

@sysadminmatmoz
Copy link
Member Author

I don't get the coveralls stats; if I look at only my module, the coverage increases.

@pedrobaeza
Copy link
Member

You are adding code without tests, that's why the coverage decreases.

👍 adding the known issues I commented in the other PR

@oca-clabot
Copy link

Hey @sysadminmatmoz, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@sysadminmatmoz
Copy link
Member Author

My CLA is there for quite some time! Even from before I became an OCA member.

@StefanRijnhart
Copy link
Member

Please rebase instead of merging the target branch. If you rebase now, you should get rid of the merge commits. It's some of the commits included in your merges that triggered the CLA warning.

@sysadminmatmoz
Copy link
Member Author

Done. Thanks.

@sysadminmatmoz
Copy link
Member Author

Finally all the checks are ok 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the new versioning convention and change to 8.0.1.0.0

@StefanRijnhart
Copy link
Member

Just some nags but generally good, thanks!

@sysadminmatmoz
Copy link
Member Author

Ok, I cleaned it further.
Regarding the contributors part: only in the server-tools there are 4 other modules with a openerp.py file set like that, but there are even a lot more of them in the other OCA repositories, and I took them as an example for a module, that is committed by someone that is not the original author.

@StefanRijnhart
Copy link
Member

Thanks! 👍

@StefanRijnhart StefanRijnhart added this to the 8.0 milestone Oct 16, 2015
pedrobaeza added a commit that referenced this pull request Oct 16, 2015
Module base_module_doc_rst migrated from version 6.1
@pedrobaeza pedrobaeza merged commit 0e4136d into OCA:8.0 Oct 16, 2015
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants