Skip to content

Keywords and material state container for TPSA #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
svenn-t wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Keywords and material state container for TPSA #4846

svenn-t wants to merge 4 commits into from

Conversation

@svenn-t
Copy link
Contributor

@svenn-t svenn-t commented Dec 2, 2025

Companion PR to OPM/opm-simulators#6650.

Introduces keyword TPSA for activating two-point stress approximation (TPSA) geomechanics simulator. Furthermore, new geomechanical parameter keywords LAME and SMODULUS for Lame's parameters commonly used in TPSA implementations. Lastly, a new (simple) container for material quantities is implemented, similar to fluid state containers.

@svenn-t svenn-t mentioned this pull request Dec 2, 2025
Draft
@totto82 totto82 added the manual:new-feature This is a new feature and should be described in the manual label Dec 2, 2025
@totto82
Copy link
Member

totto82 commented Dec 2, 2025

jenkins build this please

@totto82
Copy link
Member

totto82 commented Dec 2, 2025

jenkins build this opm-simulators=6650 please

3 similar comments
@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

akva2
akva2 reviewed Dec 3, 2025
View reviewed changes
@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

4 similar comments
@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

@totto82
Copy link
Member

totto82 commented Dec 3, 2025

jenkins build this opm-simulators=6650 please

@svenn-t svenn-t mentioned this pull request Dec 4, 2025
Draft
@akva2
Copy link
Member

akva2 commented Dec 4, 2025

jenkins build this please

akva2
akva2 reviewed Dec 4, 2025
View reviewed changes
Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

@svenn-t
Copy link
Contributor Author

svenn-t commented Dec 4, 2025

Thanks for the comments @akva2. I have addressed them in the new update.

@totto82
Copy link
Member

totto82 commented Dec 5, 2025

jenkins build this opm-simulators=6650 please

akva2
akva2 approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akva2
Copy link
Member

akva2 commented Dec 5, 2025

jenkins build this please

@totto82
Copy link
Member

totto82 commented Dec 15, 2025

jenkins build this opm-simulators=6650 please

@totto82
Copy link
Member

totto82 commented Dec 16, 2025

jenkins build this opm-simulators=6650 opm-tests=1440 please

@svenn-t
TPSA related keywords and material state container.
c3a947f 
- LAME and SMODULUS = Lame's first parameter and shear modulus
- TPSA keyword for options to coupling Flow and TPSA
- MaterialStateTPSA container for TPSA quantities
@svenn-t
Fix EOL at EOF
9672e5f
@svenn-t
Fix formatting and input variables
62c83f1
@svenn-t
Add material state test to link with dune-common
f047cd5
@totto82
Copy link
Member

totto82 commented Dec 19, 2025

jenkins build this opm-simulators=6650 opm-tests=1440 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akva2 akva2 akva2 approved these changes

Assignees

No one assigned

Labels

manual:new-feature This is a new feature and should be described in the manual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@svenn-t @totto82 @akva2