Merged
Conversation
Member
Author
|
jenkins build this with downstreams please |
joakim-hove
force-pushed
the
change-time-map-api
branch
7 times, most recently
from
36f0962 to
edff16f
Compare
joakim-hove
force-pushed
the
change-time-map-api
branch
from
2e4ea10 to
42c3cc9
Compare
Member
Author
|
jenkins build this with downstreams please |
Member
Author
|
jenkins build this with downstreams ewoms=198 please |
1 similar comment
Member
Author
|
jenkins build this with downstreams ewoms=198 please |
Member
Author
|
jenkins build this with downstreams ewoms=198 opm-simulators=1222 please |
1 similar comment
Member
Author
|
jenkins build this with downstreams ewoms=198 opm-simulators=1222 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boost datetime internally uses a 32 bit integer type to represent time, and has a 2038 problem.
In the opm-parser code the class
TimeMapuses boost datetime internally, we intend to change that tostd::time_t- which is a 64 bit integral type on any 64 bit linux, and also on any reasonably new 32bit linux.The current PR will just change the
TimeMap::operator[]to returnstd::time_tinstead of boost datetime. The code still uses boost datetime internally.Downstream:
ewoms: OPM/opm-models#198
simulators: OPM/opm-simulators#1222