Changed to TimeMap api - using std::time_t#1222
Conversation
|
Looks fine, feel free to merge when upstream is done and tests are green. Just one tiny condition: make a sanity-test run of SPE1 or something to verify that printed dates remain the same. |
7786154 to
66931cb
Compare
|
jenkins build this opm-parser=1092 ewoms=198 please |
Of course I can do that - but seriously; we have tests for this?! |
No, which is why I asked you to verify it... |
Hopefully we have soon: OPM/opm-output#195 |
Well - that was a slightly larger job than I thought: so although I still think we should have such a test I have done a manual sanity check of SPE1 now. |
I agree, and appreciate both the test and the interim manual check! I guess this should be merged, then? |
Downstream of: OPM/opm-parser#1092