This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Fix Utilities.host/Utilities.platform #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, "host" would return "undefined" instead of web. This also fixes OfficeDev#133
Member
Author
|
@sumurthy , @akrantz , @LouMM : could you please review, merge in, and release a new package? Thanks! |
akrantz
reviewed
May 6, 2019
akrantz
approved these changes
May 6, 2019
Member
Author
|
@akrantz , I see you merged the branch into master. Does that kick off an npm publish automatially? Or if not, can you or @sumurthy do one manually? (Note, you may also want to merge in #125 at the same time, which is another trivial PR, and publish an update that contains both -- I know Yutao has been waiting on it for several months now...) |
Contributor
|
@Zlatkovsky I actually don't know. I don't normally work in this repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, "host" would return "undefined" instead of web.
This also fixes #133