Skip to content

Android v1 embedding removal for OneSignal v3 #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Android v1 embedding removal for OneSignal v3 #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3dab6c1
Release commit
jennantilla Mar 26, 2024
4ec2671
Merge pull request #866 from OneSignal/rel/3.5.3
jennantilla Mar 26, 2024
6e1b1bc
release commit 3.5.4
nan-li Oct 8, 2024
686649c
Merge pull request #962 from OneSignal/rel/3.5.4
nan-li Oct 9, 2024
52afc30
Remove Android v1 embedding
Zazo032 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
group 'com.onesignal.flutter'
version '3.5.2'
version '3.5.4'

buildscript {
repositories {
Expand Down Expand Up @@ -38,5 +38,5 @@ android {
}

dependencies {
api 'com.onesignal:OneSignal:4.8.7'
api 'com.onesignal:OneSignal:4.8.10'
}
1 change: 0 additions & 1 deletion android/src/main/java/com/onesignal/flutter/OneSignalInAppMessagingController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry.Registrar;

public class OneSignalInAppMessagingController extends FlutterRegistrarResponder implements MethodCallHandler {
private MethodChannel channel;
Expand Down
1 change: 0 additions & 1 deletion android/src/main/java/com/onesignal/flutter/OneSignalOutcomeEventsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry;
import io.flutter.plugin.common.PluginRegistry.Registrar;

class OSFlutterOutcomeEventsHandler extends FlutterRegistrarResponder implements OneSignal.OutcomeCallback {
private Result result;
Expand Down
21 changes: 0 additions & 21 deletions android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry;
import io.flutter.plugin.common.PluginRegistry.Registrar;
import io.flutter.view.FlutterNativeView;

/** OnesignalPlugin */
public class OneSignalPlugin
Expand Down Expand Up @@ -120,24 +117,6 @@ public void onReattachedToActivityForConfigChanges(@NonNull ActivityPluginBindin
public void onDetachedFromActivityForConfigChanges() {
}

// This static method is only to remain compatible with apps that don’t use the v2 Android embedding.
@Deprecated()
@SuppressLint("Registrar")
public static void registerWith(Registrar registrar) {
final OneSignalPlugin plugin = new OneSignalPlugin();
plugin.init(registrar.activeContext(), registrar.messenger());

// Create a callback for the flutterRegistrar to connect the applications onDestroy
registrar.addViewDestroyListener(new PluginRegistry.ViewDestroyListener() {
@Override
public boolean onViewDestroy(FlutterNativeView flutterNativeView) {
// Remove all handlers so they aren't triggered with wrong context
plugin.onDetachedFromEngine();
return false;
}
});
}

@Override
public void onMethodCall(MethodCall call, Result result) {
if (call.method.contentEquals("OneSignal#setAppId"))
Expand Down
1 change: 0 additions & 1 deletion android/src/main/java/com/onesignal/flutter/OneSignalTagsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry;
import io.flutter.plugin.common.PluginRegistry.Registrar;

/**
* Created by bradhesse on 7/17/18.
Expand Down
4 changes: 2 additions & 2 deletions ios/onesignal_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
Pod::Spec.new do |s|
s.name = 'onesignal_flutter'
s.version = '3.5.2'
s.version = '3.5.4'
s.summary = 'The OneSignal Flutter SDK'
s.description = 'Allows you to easily add OneSignal to your flutter projects, to make sending and handling push notifications easy'
s.homepage = 'https://www.onesignal.com'
Expand All @@ -13,7 +13,7 @@ Pod::Spec.new do |s|
s.source_files = 'Classes/**/*'
s.public_header_files = 'Classes/**/*.h'
s.dependency 'Flutter'
s.dependency 'OneSignalXCFramework', '3.12.7'
s.dependency 'OneSignalXCFramework', '3.12.10'
s.ios.deployment_target = '9.0'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: onesignal_flutter
description: OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your flutter app with OneSignal
version: 3.5.2
version: 3.5.4
author: Brad Hesse <brad@onesignal.com>, Josh Kasten <josh@onesignal.com>
homepage: https://github.com/OneSignal/OneSignal-Flutter-SDK

Expand Down