Skip to content

Be more picky about anchor nodes #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lentinj wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Be more picky about anchor nodes #981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
918230f
WIP: position_helper: Stash chosen anchor_node so we can see it in debug
lentinj Aug 7, 2025
80c3b11
WIP: position_helper: anchor to nodes that are on-screen *and* reason…
lentinj Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions OZprivate/rawJS/OZTreeModule/src/position_helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,9 @@ function reanchor_at_node(node, root_node) {
// Set graphref false everywhere
deanchor(root_node);

// Anchor to this node
tree_state.anchor_node = node; // NB: Only saved for debugging purposes

// Walk up tree from (node), setting graphref
while (node.upnode) {
node.graphref = true;
Expand All @@ -391,16 +394,25 @@ function reanchor_at_node(node, root_node) {
}

/**
* Walk tree, anchoring to the first node on-screen that has 2.2 < node.rvar < 22000
* Walk tree, anchoring to the first node that is both on screen and of a reasonable size
* (i.e. set graphref on this node and it's ancestors)
*
* Reasonable size here means we should ignore high-up nodes whose bounding boxes encompass half of
* insects in a balanced tree (e.g.)
*
* For debugging, you can draw the current anchor node with:
* onezoom.config.debug_bounding_box = (node => node === onezoom.tree_state.anchor_node ? 0x03 : 0)
* ...or add a browser watch condition of:
* onezoom.tree_state.anchored_node + ' ' + onezoom.tree_state.anchored_node.rvar
*/
function reanchor(node) {
// If this node (or it's desendents) aren't visible, don't bother
if (!node.dvar) return;

node.graphref = true;
if (node.gvar || !node.has_child || (node.rvar > 2.2 && node.rvar < 22000)) {
if (!node.has_child || node.gvar && (node.rvar > 1 && node.rvar < 2200)) {
// Anchor to this node
tree_state.anchor_node = node; // NB: Only saved for debugging purposes
tree_state.xp = node.xvar;
tree_state.yp = node.yvar;
tree_state.ws = node.rvar / 220;
Expand Down
Loading