Conversation
|
update: since this test env requires openfe (for benchmarking?), numpy 2.0 support will happen after we release |
This seems like a bit of a cyclic dependency. From what I can tell it only ever uses openfe for viz things, I'll open an issue. |
yes exactly, thank you! |
|
No API break detected ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 13 13
Lines 661 661
=======================================
Hits 649 649
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think its bad to have this in the env to ensure that we are pulling in numpy 2 |
leave this in draft until dependencies are resolved. currently blocked by
openff-modelsruff NPY-201 check passes
related to OpenFreeEnergy/openfe#1239 (comment)
Checklist
newsentryDevelopers certificate of origin