Add support for result tokenizables to warehouse#1763
Add support for result tokenizables to warehouse#1763atravitz merged 6 commits intoOpenFreeEnergy:feat/warehousefrom
Conversation
|
One question I have on this before we review is whether we should be scoping tokenizables that each store can hold? My guess is yes, but I wasn't 100% sure. Either way, figured I would get this out so we can start the process here. |
|
pre-commit.ci autofix |
|
We may need to rebase the base branch so that tests can pass since they don't seem to be because of me. |
|
In discussion with @atravitz we need to cherry-pick this into two PRs rather than keeping it monolithic. |
09f546c to
8891754
Compare
…o feat/result-objects
…o feat/result-objects
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/warehouse #1763 +/- ##
=================================================
Coverage ? 92.19%
=================================================
Files ? 197
Lines ? 17179
Branches ? 0
=================================================
Hits ? 15838
Misses ? 1341
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Related to #1582.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofixbefore requesting review.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin