test: cleanup warehouse test to be more modular#1809
Merged
atravitz merged 4 commits intoOpenFreeEnergy:feat/warehousefrom Jan 28, 2026
Merged
test: cleanup warehouse test to be more modular#1809atravitz merged 4 commits intoOpenFreeEnergy:feat/warehousefrom
atravitz merged 4 commits intoOpenFreeEnergy:feat/warehousefrom
Conversation
7 tasks
…o test/refactor-warehouse
…o test/refactor-warehouse
…o test/refactor-warehouse
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/warehouse #1809 +/- ##
=================================================
Coverage ? 92.20%
=================================================
Files ? 197
Lines ? 17194
Branches ? 0
=================================================
Hits ? 15854
Misses ? 1340
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
approved these changes
Jan 23, 2026
Contributor
atravitz
left a comment
There was a problem hiding this comment.
lgtm, but I do expect we'll find some additional ways to stress-test this as we use it.
| ) | ||
|
|
||
| # | ||
| @pytest.mark.parametrize("fixture", ["benzene_variants_star_map"]) |
Contributor
There was a problem hiding this comment.
I'm guessing we're leaving this parameterize to make it easier to add more test cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and expands the storage tests in
test_warehouse.pyto more comprehensively cover both thesetupandresultstores. The main improvements are the parameterization of tests to run against both store types, and the generalization of helper methods to support this. This increases test coverage and improves clarity.Test coverage and parameterization improvements:
"setup"and"result"stores, ensuring both are tested equally._test_store_load_same_processand_test_store_load_different_processare refactored to accept astore_nameparameter, allowing them to work with either store and improving code reuse.test_deletemethod is updated to use the new parameterization and helper method, ensuring deletion logic is tested for both stores.It is important to note that this PR will fail until #1763 is merged.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin