Skip to content

Update submodules: remove umetaflow-gui, rename FLASHViewer to FLASHA…#171

Draft
poshul wants to merge 4 commits intomainfrom
repoint_submods
Draft

Update submodules: remove umetaflow-gui, rename FLASHViewer to FLASHA…#171
poshul wants to merge 4 commits intomainfrom
repoint_submods

Conversation

@poshul
Copy link
Contributor

@poshul poshul commented Feb 4, 2026

…pp with new URL

Summary by CodeRabbit

Chores

  • Updated project dependencies: replaced FLASHViewer component with FLASHApp
  • Removed umetaflow-gui submodule reference

@poshul poshul requested a review from t0mdavid-m February 4, 2026 09:09
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Git submodule configuration is updated to remove umetaflow-gui and FLASHViewer, while adding FLASHApp as a replacement submodule. Submodule commit pointers are removed accordingly from the affected modules.

Changes

Cohort / File(s) Summary
Git Submodule Configuration
.gitmodules
Removed submodule definitions for umetaflow-gui and FLASHViewer; added new FLASHApp submodule pointing to https://github.com/OpenMS/FLASHApp.git.
Submodule Commit References
FLASHViewer, umetaflow-gui
Removed subproject commit pointer metadata from both submodules following their removal from the configuration.

Poem

🐰 The submodules hop and skip away,
FLASHApp takes their place today!
New paths and pointers now aligned,
Git's garden reorganized and refined! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing umetaflow-gui and renaming/updating FLASHViewer to FLASHApp, matching the PR objectives and changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch repoint_submods

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @.gitmodules:
- Around line 7-9: docker-compose.yml still references deleted/renamed
submodules; update the service, volume and command names to match the new
`.gitmodules` layout: rename the FLASHViewer service and its build context from
./FLASHViewer to ./FLASHApp and update any volume names like
workspaces-flashviewer to workspaces-flashapp; remove (or replace) the umetaflow
service that uses build context ./umetaflow-gui and volume
workspaces-umetaflow-gui, and delete its command `streamlit run
umetaflow-gui/Home.py` (or change it to the new service entrypoint if there's a
replacement); ensure all service names, build.context values and volume keys
consistently use FLASHApp where FLASHViewer was used and remove references to
umetaflow-gui throughout the file so compose up no longer refers to deleted
submodules.
- Around line 7-9: docker-compose.yml still references removed/renamed
submodules: update the FLASHViewer service to use build context ./FLASHApp
(instead of ./FLASHViewer) and remove the entire umetaflow service plus any
volumes and commands that point to the removed submodule (remove volume
workspaces-umetaflow-gui and any command paths like umetaflow-gui/Home.py); also
search for any other mentions of umetaflow-gui and replace or delete them so all
service build contexts and volume names match the new FLASHApp submodule and no
service references non-existent directories.

@t0mdavid-m
Copy link
Member

Why are we removing umetaflow?

@t0mdavid-m
Copy link
Member

Seems like the FLASHApp remote change was not committed and the commit hashs point to nothing currently. Interesting.

@poshul poshul marked this pull request as draft February 4, 2026 09:34
@poshul
Copy link
Contributor Author

poshul commented Feb 4, 2026

Why are we removing umetaflow?

Should be fixed now. The repo was renamed from umetaflow-gui to umetaflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants