Skip to content

Conversation

@shashikala1998
Copy link
Contributor

Why is this change needed?

Maximum number field is not aligned properly

How was the change implemented?

By grouping fields properly

New unit tests

N/A

Unit tests executed by the author

N/A

How to test manually

  1. Create a program in OpenSPP with "Cash" as the entitlement manager.
  2. Open the program, go to the Configuration tab, and click Entitlement Manager.
  3. In the Cash Entitlement Manager modal, click Add a line.
  4. Notice that the maximum number label is aligned with its input field.
Screenshot 2025-03-20 at 18 49 20

Related links

#729

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (121ca77) to head (fa2cb3e).
Report is 14 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #783      +/-   ##
==========================================
+ Coverage   75.02%   75.09%   +0.06%     
==========================================
  Files         727      729       +2     
  Lines       19228    19274      +46     
  Branches     2400     2400              
==========================================
+ Hits        14426    14473      +47     
  Misses       4293     4293              
+ Partials      509      508       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shashikala1998 shashikala1998 removed the request for review from jeremi March 21, 2025 02:46
@shashikala1998 shashikala1998 merged commit aa7a32f into 17.0 Mar 25, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@jeremi jeremi deleted the 729-cash-entitlement branch September 15, 2025 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distorted input field for maximum number when creating cash entitlement

4 participants