-
Notifications
You must be signed in to change notification settings - Fork 1
Support sidekiq 8.x #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| source "https://gems.contribsys.com/" do | ||
| gem "sidekiq-pro", "7.3.0" | ||
| gem "sidekiq-pro", ">= 7.3.0", "< 9" | ||
| end | ||
|
|
||
| gem "sidekiq", "7.3.0" | ||
| gem "sidekiq", ">= 7.3.0", "< 9" | ||
|
|
||
| # Specify your gem's dependencies in simplekiq.gemspec | ||
| gemspec |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| source "https://rubygems.org" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't actually seen this "multiple gemfiles" trick before but I guess it makes sense. In my mind "multiple Gemfile.locks" seems more correct but is probably harder to manage in practice?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I think it's harder to manage and we also explicitly got rid of the Gemfile.lock before doximity@9a29f9c |
||
|
|
||
| source "https://gems.contribsys.com/" do | ||
| gem "sidekiq-pro", "7.3.0" | ||
| end | ||
|
|
||
| gem "sidekiq", "7.3.0" | ||
|
|
||
| # Specify your gem's dependencies in simplekiq.gemspec | ||
| gemspec | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,20 @@ FileList["tasks/*.rake"].each { |task| load task } | |
| RSpec::Core::RakeTask.new(:spec) | ||
|
|
||
| task default: :spec | ||
|
|
||
| namespace :test do | ||
| desc "Test against Sidekiq 8.0 (default)" | ||
| task :sidekiq8 do | ||
eapache-opslevel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| sh "bundle install" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you already have 7.3 installed, does this actually force 8? because 7.3 still satisfies the default gemfile? |
||
| sh "bundle exec rspec" | ||
| end | ||
|
|
||
| desc "Test against Sidekiq 7.3" | ||
| task :sidekiq7 do | ||
| sh "bundle install --gemfile=Gemfile.sidekiq7" | ||
| sh "bundle exec rspec" | ||
| end | ||
|
|
||
| desc "Test against all Sidekiq versions" | ||
| task :all => [:sidekiq8, :sidekiq7] | ||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes a check and will get simplekiq to platinum https://app.opslevel.com/components/simplekiq/maturity-report?checkId=Z2lkOi8vb3BzbGV2ZWwvQ2hlY2tzOjpQYWNrYWdlVmVyc2lvbi8yNTM4Mw