Conversation
Farjaad
force-pushed
the
farjaad/support-sidekiq-8
branch
3 times, most recently
from
fe27ce9 to
880ad4d
Compare
Farjaad
force-pushed
the
farjaad/support-sidekiq-8
branch
from
880ad4d to
037efcd
Compare
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Install Ruby and gems | ||
| uses: actions/checkout@v5 |
There was a problem hiding this comment.
this fixes a check and will get simplekiq to platinum https://app.opslevel.com/components/simplekiq/maturity-report?checkId=Z2lkOi8vb3BzbGV2ZWwvQ2hlY2tzOjpQYWNrYWdlVmVyc2lvbi8yNTM4Mw
| @@ -0,0 +1,10 @@ | |||
| source "https://rubygems.org" | |||
There was a problem hiding this comment.
I haven't actually seen this "multiple gemfiles" trick before but I guess it makes sense. In my mind "multiple Gemfile.locks" seems more correct but is probably harder to manage in practice?
There was a problem hiding this comment.
yeah I think it's harder to manage and we also explicitly got rid of the Gemfile.lock before doximity@9a29f9c
|
I poked through the sidekiq changelog/upgrade guide. A bunch of stuff to do with job batches (which this gem uses) have changed, but I think the changes are all in the internals, and this gem only uses the public interface, so we should be good. |
Farjaad
force-pushed
the
farjaad/support-sidekiq-8
branch
3 times, most recently
from
3f5ad92 to
f495d25
Compare
Farjaad
force-pushed
the
farjaad/support-sidekiq-8
branch
from
f495d25 to
0d65065
Compare
Farjaad
force-pushed
the
farjaad/support-sidekiq-8
branch
from
1959817 to
206e519
Compare
| namespace :test do | ||
| desc "Test against Sidekiq 8.0 (default)" | ||
| task :sidekiq8 do | ||
| sh "bundle install" |
There was a problem hiding this comment.
if you already have 7.3 installed, does this actually force 8? because 7.3 still satisfies the default gemfile?
3 participants
Simplekiq needs to support sidekiq 8.x before we can upgrade sidekiq in the monolith.