Skip to content

Fix GMRES polynomial overrun #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevendargaville merged 2 commits into from
Jan 26, 2026
Merged

Fix GMRES polynomial overrun #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d60d2
Add -fp_trap to CI
stevendargaville Jan 26, 2026
0ec7c34
Prevent fp exception by ensuring multiplication only happens in allow…
stevendargaville Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dockerfiles/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ LABEL description="PFLARE"
ENV CHECKOUT_BRANCH=$BRANCH
ENV PETSC_ARCH=$ARCH
# -on_error_abort ensures any test failures are caught and the build fails
ENV PETSC_OPTIONS="-on_error_abort"
# fp trap turns on floating point exception trapping in petsc
ENV PETSC_OPTIONS="-on_error_abort -fp_trap on"

WORKDIR /build

Expand Down
2 changes: 1 addition & 1 deletion src/Gmres_Poly.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,7 @@ subroutine mat_mult_powers_share_sparsity_cpu(matrix, poly_order, poly_sparsity_
! ~~~~~~~~~~~
if (ncols /= 0 .AND. coefficients(term) /= 0d0) then
call MatSetValues(cmat, one, [global_row_start + i_loc-1], ncols, cols, &
coefficients(term) * vals_power_temp, ADD_VALUES, ierr)
coefficients(term) * vals_power_temp(1:ncols), ADD_VALUES, ierr)
end if

! This should now have the value of A^(term-1) in it
Expand Down
Loading