Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Conversation

@kitlith
Copy link
Contributor

@kitlith kitlith commented Jul 13, 2020

Depends on #127, can rebase, etc., once that gets in. Until then, please ignore the first two commits that are part of #127 .

@kitlith kitlith force-pushed the lifecycle-god-class branch from 86d3e3d to c9e0c16 Compare July 16, 2020 02:17
@kitlith
Copy link
Contributor Author

kitlith commented Jul 16, 2020

There was some interesting history rewriting going on here, so i'm going to detail it while waiting for CI.

for the interested:

  • First, a bit of git rebase -i master to reorder the commits so the fixup!s were next to the commits i wanted to merge them into.
  • more git rebase -i master to actually merge the fixups into the original commits
  • Finally, a git rebase --onto origin/master event-dispatcher-module to take care of the fact that the event-dispatcher-module branch has already been squashed and merged.

@kitlith kitlith merged commit b2376b9 into master Jul 16, 2020
@kitlith kitlith deleted the lifecycle-god-class branch July 19, 2020 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants