This repository was archived by the owner on Apr 14, 2024. It is now read-only.
Open
Conversation
This also will pull the blacklist from the user's account automatically if logged in. The user can disable or edit the list if they wish.
TachisAlopex
force-pushed
the
add-login-and-blacklist
branch
from
4d37626 to
c54de55
Compare
Collaborator
|
Hi thanks so much for the contribution! I take august for vacations, so I'll look more closely at this in a bit! Thank you so much <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I would like to add two features to the e621 getter, login and blacklist:
Login will allow the user to use the votedup:me tag (and voted/voteddown...), as well as being able to use private sets and load the user's blacklist.
When you check the login, it will prompt for credentials:
After filling it out and clicking "Save credentials" it authenticates and persists your login information (will save to localStorage, but will not be exported in the save/load control
If your information is wrong, it will show an error string that will go away after editing either field:
When you put in this information, it will automatically fetch and fill out the blacklist:
You can modify the blacklist (or turn it off altogether). If you didn't login, you can still manually use the blacklist. It defaults to an empty textbox (which won't filter anything)
So what do you think? I tried to stay consistent with the rest of the style of the code, but it's my first time working in React, so let me know if anything is off. Thanks!
Edit: slightly changed the wording, and this time made sure my code was run through the linter. Thanks!