Fixes exception UninitializedStaticallyTypedParameterException when declaring a parameter without default value#27
Open
JafarAbdi wants to merge 3 commits intoPickNikRobotics:ros2from
Open
Conversation
…ion when declaring a parameter without default value
AndyZe
reviewed
May 25, 2022
AndyZe
left a comment
AndyZe
left a comment
There was a problem hiding this comment.
I'll wait on somebody else to approve this one. It seems like a lot of added code just to fix a nitpicky compiler warning, if I understand right.
Contributor
Author
It's an exception not a warning, I updated the title |
JafarAbdi
changed the title
stephanie-eng
approved these changes
May 25, 2022
stephanie-eng
left a comment
stephanie-eng
left a comment
There was a problem hiding this comment.
Tested this with moveit/moveit_task_constructor#365, and this solves the UninitializedStaticallyTypedParameterException error that prevented the demo from working
vatanaksoytezer
approved these changes
May 25, 2022
vatanaksoytezer
left a comment
vatanaksoytezer
left a comment
There was a problem hiding this comment.
Lgtm, had a similar problem in another project and couldn't come up with something better than this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I should push it upstream to replace https://github.com/ros2/rclcpp/blob/master/rclcpp/include/rclcpp/node_impl.hpp#L220-L232