Skip to content

Conversation

@noahho
Copy link
Collaborator

@noahho noahho commented Dec 30, 2025

Summary

  • move first-party compatibility testing into the main CI workflow
  • run the first-party tests after linting and make them finish before doing GPU checks
  • remove the standalone first_party_compatibility workflow file

This reduces the overhead of running first party compatability every time and allows us to make it interact with the rest of the CI workflow by moving in the same file. Separating into multiple workflows seems to not allow any interdependency

I thought this was a one line change first (before realizing the separate files mean the workflows are separate), it's not the most important issue TBH but small optimization

Now:

image

Before:

image

And separate first party compat

Testing

  • not run (CI workflow change only)

Codex Task

@noahho noahho requested a review from a team as a code owner December 30, 2025 08:22
@noahho noahho requested review from Copilot and simo-prior and removed request for a team and Copilot December 30, 2025 08:22
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@noahho noahho removed the request for review from simo-prior December 30, 2025 08:23
@noahho noahho changed the title Integrate first-party compatibility checks into CI [WIP] Integrate first-party compatibility checks into CI Dec 30, 2025
Copilot AI review requested due to automatic review settings December 31, 2025 09:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates first-party compatibility testing into the main CI workflow by removing the standalone first_party_compatibility.yml workflow file and integrating its job into ci.yml. This simplifies workflow management and ensures first-party package tests run as part of the standard CI pipeline.

Key Changes

  • Moved the test_first_party_packages job from a standalone workflow into the main CI workflow, positioned after linting checks
  • Updated the GPU test job to depend on both the Ubuntu-latest 3.14 tests and the first-party compatibility tests
  • Removed the standalone first_party_compatibility.yml workflow file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/first_party_compatibility.yml Deleted standalone workflow file for first-party compatibility testing
.github/workflows/ci.yml Added test_first_party_packages job (lines 180-237) that tests tabpfn-extensions and tabpfn-time-series; updated test_gpu job dependencies to include the new first-party tests
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:242

  • The comment mentions "the ubuntu-latest 3.14 workflow above" but the GPU test now depends on both test_ubuntu_latest_314 and test_first_party_packages jobs. The comment should be updated to reflect that the GPU test waits for both the Ubuntu-latest 3.14 job and the first-party compatibility tests to complete.
  # GPU: To save compute we only want to execute this workflow once
  # a CPU workflow has passed. Hence, this workflow depends on the
  # ubuntu-latest 3.14 workflow above.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noahho noahho requested a review from oscarkey December 31, 2025 09:46
@noahho noahho changed the title [WIP] Integrate first-party compatibility checks into CI Integrate first-party compatibility checks into CI Dec 31, 2025
@noahho noahho changed the title Integrate first-party compatibility checks into CI [Nit] Integrate first-party compatibility checks into CI Dec 31, 2025
@oscarkey
Copy link
Contributor

oscarkey commented Jan 5, 2026

At the moment these checks are "fyi" and don't block merge because it can be annoying to fix them: we potentially have to update main of the extensions repo to point at the unreleased tabpfn branch, release tabpfn, point extensions back at pypi again.

It would be nice to come up with a better way to do this, but for now we could remove the block of the gpu workflow on the first-party compatibility checks?

@noahho
Copy link
Collaborator Author

noahho commented Jan 5, 2026

At the moment these checks are "fyi" and don't block merge because it can be annoying to fix them: we potentially have to update main of the extensions repo to point at the unreleased tabpfn branch, release tabpfn, point extensions back at pypi again.

It would be nice to come up with a better way to do this, but for now we could remove the block of the gpu workflow on the first-party compatibility checks?

I'm not quite sure I understand! Maybe we can quickly sync tmrw in person?

@noahho noahho enabled auto-merge (squash) January 8, 2026 09:19
@noahho
Copy link
Collaborator Author

noahho commented Jan 8, 2026

We got this now after @oscarkey comments
image

Copy link
Contributor

@oscarkey oscarkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@noahho noahho merged commit 6b8433d into main Jan 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants