-
Notifications
You must be signed in to change notification settings - Fork 537
[Nit] Integrate first-party compatibility checks into CI #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates first-party compatibility testing into the main CI workflow by removing the standalone first_party_compatibility.yml workflow file and integrating its job into ci.yml. This simplifies workflow management and ensures first-party package tests run as part of the standard CI pipeline.
Key Changes
- Moved the
test_first_party_packagesjob from a standalone workflow into the main CI workflow, positioned after linting checks - Updated the GPU test job to depend on both the Ubuntu-latest 3.14 tests and the first-party compatibility tests
- Removed the standalone
first_party_compatibility.ymlworkflow file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/first_party_compatibility.yml |
Deleted standalone workflow file for first-party compatibility testing |
.github/workflows/ci.yml |
Added test_first_party_packages job (lines 180-237) that tests tabpfn-extensions and tabpfn-time-series; updated test_gpu job dependencies to include the new first-party tests |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:242
- The comment mentions "the ubuntu-latest 3.14 workflow above" but the GPU test now depends on both test_ubuntu_latest_314 and test_first_party_packages jobs. The comment should be updated to reflect that the GPU test waits for both the Ubuntu-latest 3.14 job and the first-party compatibility tests to complete.
# GPU: To save compute we only want to execute this workflow once
# a CPU workflow has passed. Hence, this workflow depends on the
# ubuntu-latest 3.14 workflow above.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
At the moment these checks are "fyi" and don't block merge because it can be annoying to fix them: we potentially have to update main of the extensions repo to point at the unreleased tabpfn branch, release tabpfn, point extensions back at pypi again. It would be nice to come up with a better way to do this, but for now we could remove the block of the gpu workflow on the first-party compatibility checks? |
I'm not quite sure I understand! Maybe we can quickly sync tmrw in person? |
|
We got this now after @oscarkey comments |
oscarkey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect!

Summary
This reduces the overhead of running first party compatability every time and allows us to make it interact with the rest of the CI workflow by moving in the same file. Separating into multiple workflows seems to not allow any interdependency
I thought this was a one line change first (before realizing the separate files mean the workflows are separate), it's not the most important issue TBH but small optimization
Now:
Before:
And separate first party compat
Testing
Codex Task