Drop MySQL 4.1/5.0/5.1 support, add 8.4/9.x to supported versions#19
Drop MySQL 4.1/5.0/5.1 support, add 8.4/9.x to supported versions#19renecannao merged 1 commit intomasterfrom
Conversation
…ersions These ancient MySQL versions (15+ years old) are no longer tested or maintained. Removes 5.1 tarball entries and updates supported version lists and test defaults to focus on 5.5+ and include modern 8.4/9.x.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRemoved support for MySQL versions 4.1, 5.0, and 5.1 across configuration files and tarball metadata. Added support for MySQL 8.4, 9.0, 9.1, and 9.2. Changes span global version lists, test setup defaults, and tarball registry entries totaling 40 lines affected. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's MySQL version support by deprecating very old and unsupported versions (4.1, 5.0, 5.1) and integrating newer, more current versions (8.4, 9.0, 9.1, 9.2). This change streamlines maintenance, removes outdated dependencies, and ensures compatibility with contemporary database environments, while also updating testing configurations to reflect these changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request drops support for older MySQL versions (4.1, 5.0, 5.1) and adds support for newer ones (8.4, 9.x). The changes correctly update the supported version lists and test configurations. However, I've identified a couple of areas for improvement to ensure consistency. The tarball definitions for MySQL 4.1 and 5.0 remain in downloads/tarball_list.json despite support being dropped, and the test setup in ts/setup.go doesn't include all the newly supported versions. I've provided specific suggestions to address these inconsistencies.
I am having trouble creating individual review comments. Click here to see my feedback.
downloads/tarball_list.json (101-112)
You've removed the tarball entries for MySQL 5.1, which is consistent with dropping support for it. However, the entries for MySQL 4.1 and 5.0 are still present in this file. To be fully consistent with dropping support for versions 4.1, 5.0, and 5.1 as mentioned in the PR description and reflected in globals/globals.go, shouldn't the tarball definitions for 4.1 and 5.0 also be removed?
ts/setup.go (119)
The SupportedMySQLVersions list in globals/globals.go was updated to include 8.4, 9.0, 9.1, and 9.2. For consistency, it would be good to also add 9.1 and 9.2 to this shortVersions slice for testing. Even if tarballs are not yet available and tests for them would be skipped, this change would make the test setup fully aligned with the newly added support.
shortVersions := []string{"5.5", "5.6", "5.7", "8.0", "8.4", "9.0", "9.1", "9.2"}
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s declared MySQL version support and test configuration to drop very old MySQL releases and recognize newer 8.4/9.x lines.
Changes:
- Removed MySQL 4.1/5.0/5.1 from supported version lists.
- Updated test short-version defaults to focus on 5.5+ and include newer major lines.
- Removed MySQL 5.1 tarball entries from the embedded tarball registry JSON.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ts/setup.go |
Updates default short-version sets used by test setup (including GitHub Actions defaults). |
globals/globals.go |
Updates exported/declared supported MySQL version lists (and “all versions” list). |
downloads/tarball_list.json |
Removes embedded tarball registry entries for MySQL 5.1. |
Comments suppressed due to low confidence (1)
downloads/tarball_list.json:112
- This tarball list still contains MySQL 5.0 entries (e.g., short_version "5.0") even though the PR title/description says 5.0 support is being dropped. If 5.0 is no longer supported, consider removing the remaining 5.0 tarballs from the embedded registry as well (or clarify in the PR description that old tarballs are intentionally kept even after dropping support).
{
"name": "mysql-5.0.96-osx10.5-x86_64.tar.gz",
"checksum": "SHA512:a5f3959732fe8b4a9cb3b41d7c2f7d869cae38ffc844989b7c98cdbf7496e6d65ea1794819d2a6aea8dd13340252a8c553dcdfbc904415ecd13adb493aa5ae68",
"OS": "Darwin",
"arch": "amd64",
"url": "https://downloads.mysql.com/archives/get/p/23/file/mysql-5.0.96-osx10.5-x86_64.tar.gz",
"flavor": "mysql",
"minimal": false,
"size": 60958921,
"short_version": "5.0",
"version": "5.0.96"
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| shortVersions := []string{"5.5", "5.6", "5.7", "8.0", "8.4", "9.0"} | ||
| if os.Getenv("GITHUB_ACTIONS") != "" { | ||
| shortVersions = []string{"5.6", "5.7", "8.0"} | ||
| shortVersions = []string{"5.7", "8.0", "8.4"} | ||
| } |
There was a problem hiding this comment.
The updated shortVersions list includes 8.4/9.0, but initializeEnv/getVersionList will silently skip versions that aren't already present locally and can't be downloaded from the embedded tarball registry. Since downloads/tarball_list.json currently has no 8.4/9.0 entries, CI/local runs are likely to not exercise these versions despite being listed here. Consider adding corresponding tarball entries, or make the test setup fail (or at least warn loudly) when a configured short version can't be resolved so the intended coverage isn't accidentally lost.
| SupportedMySQLVersions = []string{ | ||
| "4.1", "5.0", "5.1", "5.5", "5.6", "5.7", "8.0", | ||
| "5.5", "5.6", "5.7", "8.0", "8.4", "9.0", "9.1", "9.2", | ||
| } | ||
| SupportedAllVersions = []string{ | ||
| "4.1", "5.0", "5.1", "5.5", "5.6", "5.7", "8.0", | ||
| "5.5", "5.6", "5.7", "8.0", "8.4", "9.0", "9.1", "9.2", | ||
| "10.0", "10.1", "10.2", "10.3", "10.4", "10.5", |
There was a problem hiding this comment.
SupportedMySQLVersions / SupportedAllVersions now include 8.4 and 9.0–9.2, but the embedded tarball registry (downloads/tarball_list.json) currently has no entries for these short versions. If users (or downstream tools consuming ExportReferenceData) interpret these lists as versions that can be downloaded via downloads get-by-version, requests for 8.4/9.x will fail to resolve a tarball. Consider either adding seed tarball entries for the new short versions, or clarifying (in code/docs) that these “supported” lists are metadata and not tied to what the downloads registry can fetch.
Summary
SupportedMySQLVersionsandSupportedAllVersionsNote: 5.5 and 5.6 are kept for now but may be dropped in a future version.
Test plan
Summary by CodeRabbit