Skip to content

Drop MySQL 4.1/5.0/5.1 support, add 8.4/9.x to supported versions #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renecannao merged 1 commit into from
Mar 23, 2026
Merged

Drop MySQL 4.1/5.0/5.1 support, add 8.4/9.x to supported versions #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions downloads/tarball_list.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,6 @@
"short_version": "5.5",
"version": "5.5.53"
},
{
"name": "mysql-5.1.73-osx10.6-x86_64.tar.gz",
"checksum": "SHA512:9e21642d009ac736607d38b3b4dd0b566db39995dbcf1515cd73026c5362419dcf7d085407c3f89aab59bbf740e383cf6a257517ec00653ecd7382f3166bca38",
"OS": "Darwin",
"arch": "amd64",
"url": "https://downloads.mysql.com/archives/get/p/23/file/mysql-5.1.73-osx10.6-x86_64.tar.gz",
"flavor": "mysql",
"minimal": false,
"size": 81598665,
"short_version": "5.1",
"version": "5.1.73"
},
{
"name": "mysql-5.0.96-osx10.5-x86_64.tar.gz",
"checksum": "SHA512:a5f3959732fe8b4a9cb3b41d7c2f7d869cae38ffc844989b7c98cdbf7496e6d65ea1794819d2a6aea8dd13340252a8c553dcdfbc904415ecd13adb493aa5ae68",
Expand Down Expand Up @@ -278,18 +266,6 @@
"short_version": "5.5",
"version": "5.5.61"
},
{
"name": "mysql-5.1.73-linux-x86_64-glibc23.tar.gz",
"checksum": "SHA512:045cc42a1078aae77d2ba9d9e35d69df79feb33de3dc112095e669d5b298ac24ba963ac071ab7a0d3cbe917c68624c184e4d7c69c76dbf43c4df32cb2e4da1b2",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mysql.com/archives/get/p/23/file/mysql-5.1.73-linux-x86_64-glibc23.tar.gz",
"flavor": "mysql",
"minimal": false,
"size": 133630298,
"short_version": "5.1",
"version": "5.1.73"
},
{
"name": "mysql-5.0.96.tar.xz",
"checksum": "SHA512:c39621e43778cc971dc979a065b283864edcb15eb3aced59b5a596dbb56936a6f78feb141d5fb1e0213f130092cff1d93613c0b2beee8b8531796a745ad2bf4b",
Expand All @@ -302,18 +278,6 @@
"short_version": "5.0",
"version": "5.0.96"
},
{
"name": "mysql-5.1.72.tar.xz",
"checksum": "SHA512:6fc8ad76a831fc22f9b7bffed8fb4eb4575a122cebca8f5bab52dbe6454372b2f5681eb125141c2b1b5c547496e8d96686c83bdf3c4fdc390bd3614cd1060b9c",
"OS": "Linux",
"arch": "amd64",
"url": "https://raw.githubusercontent.com/datacharmer/mysql-docker-minimal/master/dbdata/mysql-5.1.72.tar.xz",
"flavor": "mysql",
"minimal": true,
"size": 10390324,
"short_version": "5.1",
"version": "5.1.72"
},
{
"name": "mysql-5.5.61.tar.xz",
"checksum": "SHA512:0cc441cc1f9ddc35cc8783aeeee3ac319d95f3aec184703a2c9197577e23899c4e102010bcc1e60809c0d780ccec8d78e387f6afecb46ad009d9a94b20e9ebe6",
Expand Down
4 changes: 2 additions & 2 deletions globals/globals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,10 +498,10 @@ var (
"sleep", "stat", "tail", "test", "[", "touch", "tr", "wc"}

SupportedMySQLVersions = []string{
"4.1", "5.0", "5.1", "5.5", "5.6", "5.7", "8.0",
"5.5", "5.6", "5.7", "8.0", "8.4", "9.0", "9.1", "9.2",
}
SupportedAllVersions = []string{
"4.1", "5.0", "5.1", "5.5", "5.6", "5.7", "8.0",
"5.5", "5.6", "5.7", "8.0", "8.4", "9.0", "9.1", "9.2",
"10.0", "10.1", "10.2", "10.3", "10.4", "10.5",
Comment on lines 500 to 505
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SupportedMySQLVersions / SupportedAllVersions now include 8.4 and 9.0–9.2, but the embedded tarball registry (downloads/tarball_list.json) currently has no entries for these short versions. If users (or downstream tools consuming ExportReferenceData) interpret these lists as versions that can be downloaded via downloads get-by-version, requests for 8.4/9.x will fail to resolve a tarball. Consider either adding seed tarball entries for the new short versions, or clarifying (in code/docs) that these “supported” lists are metadata and not tied to what the downloads registry can fetch.

Copilot uses AI. Check for mistakes.
}
// Extra executables needed for PXC
Expand Down
4 changes: 2 additions & 2 deletions ts/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ func preliminaryChecks() {
os.Exit(1)
}

shortVersions := []string{"4.1", "5.0", "5.1", "5.5", "5.6", "5.7", "8.0"}
shortVersions := []string{"5.5", "5.6", "5.7", "8.0", "8.4", "9.0"}
if os.Getenv("GITHUB_ACTIONS") != "" {
shortVersions = []string{"5.6", "5.7", "8.0"}
shortVersions = []string{"5.7", "8.0", "8.4"}
}
Comment on lines +119 to 122
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated shortVersions list includes 8.4/9.0, but initializeEnv/getVersionList will silently skip versions that aren't already present locally and can't be downloaded from the embedded tarball registry. Since downloads/tarball_list.json currently has no 8.4/9.0 entries, CI/local runs are likely to not exercise these versions despite being listed here. Consider adding corresponding tarball entries, or make the test setup fail (or at least warn loudly) when a configured short version can't be resolved so the intended coverage isn't accidentally lost.

Copilot uses AI. Check for mistakes.
customShortVersions := os.Getenv("TEST_SHORT_VERSIONS")
if customShortVersions != "" {
Expand Down
Loading