Skip to content

fix: remove dead fit_plotter.figures_2d block in interferometer/fit.py#17

Merged
Jammy2211 merged 1 commit intomainfrom
feature/category-f-removed-api-fixes
Apr 10, 2026
Merged

fix: remove dead fit_plotter.figures_2d block in interferometer/fit.py#17
Jammy2211 merged 1 commit intomainfrom
feature/category-f-removed-api-fixes

Conversation

@Jammy2211
Copy link
Copy Markdown
Collaborator

Summary

  • Category F fix: lines 179-186 referenced fit_plotter which was never instantiated and called figures_2d(...) — a method that doesn't exist on the interferometer plot API.
  • The block was latent dead code, hidden behind the earlier subplot_interferometer_dataset failure on line 101 (fixed in PyAutoGalaxy#337).
  • The subsequent aplt.subplot_fit_interferometer(fit=fit) call already visualizes residual / normalized residual / chi-squared maps, so no functionality is lost.

Test plan

🤖 Generated with Claude Code

The block at lines 179-186 referenced `fit_plotter` which was never
instantiated and called `figures_2d(...)` which does not exist on the
interferometer plot API. It was latent dead code — the original failure
on line 101 (`subplot_interferometer_dataset`) prevented execution from
ever reaching it. The subsequent `subplot_fit_interferometer(fit=fit)`
call already visualizes residual, normalized residual and chi-squared maps.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Jammy2211 Jammy2211 merged commit cd67406 into main Apr 10, 2026
@Jammy2211 Jammy2211 deleted the feature/category-f-removed-api-fixes branch April 10, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant