Skip to content

fix: remove dead fit_plotter.figures_2d block in interferometer/fit.py #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Apr 10, 2026
Merged

fix: remove dead fit_plotter.figures_2d block in interferometer/fit.py #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions notebooks/interferometer/fit.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,30 +285,6 @@
" - The `normalized_residual_map`: The `residual_map `divided by the observed dataset's `noise_map`.\n",
" - The `chi_squared_map`: The `normalized_residual_map` squared.\n",
"\n",
"For a good galaxy model where the model and galaxies are representative of the dataset\n",
"residuals, normalized residuals and chi-squareds are minimized:"
]
},
{
"cell_type": "code",
"metadata": {},
"source": [
"aplt.plot_array(array=fit.residual_map.real, title=\"Residual Map (Real)\")\n",
"fit_plotter.figures_2d(\n",
" residual_map_imag=True,\n",
" normalized_residual_map_real=True,\n",
" normalized_residual_map_imag=True,\n",
" chi_squared_map_real=True,\n",
" chi_squared_map_imag=True,\n",
")"
],
"outputs": [],
"execution_count": null
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"A subplot can be plotted which contains all of the above quantities, as well as other information contained in the\n",
"galaxies such as the image and a normalized residual map where the colorbar\n",
"goes from 1.0 sigma to -1.0 sigma, to highlight regions where the fit is poor."
Expand Down
13 changes: 0 additions & 13 deletions scripts/interferometer/fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,19 +173,6 @@
- The `normalized_residual_map`: The `residual_map `divided by the observed dataset's `noise_map`.
- The `chi_squared_map`: The `normalized_residual_map` squared.

For a good galaxy model where the model and galaxies are representative of the dataset
residuals, normalized residuals and chi-squareds are minimized:
"""
aplt.plot_array(array=fit.residual_map.real, title="Residual Map (Real)")
fit_plotter.figures_2d(
residual_map_imag=True,
normalized_residual_map_real=True,
normalized_residual_map_imag=True,
chi_squared_map_real=True,
chi_squared_map_imag=True,
)

"""
A subplot can be plotted which contains all of the above quantities, as well as other information contained in the
galaxies such as the image and a normalized residual map where the colorbar
goes from 1.0 sigma to -1.0 sigma, to highlight regions where the fit is poor.
Expand Down