Draft support for reconstructing a probability distribution#428
Draft
Draft support for reconstructing a probability distribution#428
Conversation
Pull Request Test Coverage Report for Build 9142521182Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially addresses #259 by supporting reconstructing of probability distributions in the special case where the circuit does not separate into disconnected components.
I plan to maintain this as a fork until we figure out how it should integrate with the existing code. (There might be some refactoring that would be appropriate before we integrate it.)
Demonstration notebook here.
I expect coverage to fail because I have not added tests (there's only the notebook for now), but adding tests should be pretty straightforward.Remaining action items
_decompose_qpd_measurementsshould throw an error ifcircuitsalready has a register called"qpd_measurements"README.rstcut_wiresto be compatible with classical registers